refactor(proxy): migrate PostgreSQL protocol to pg-proto - #443
Draft
freshtonic wants to merge 7 commits into
Draft
refactor(proxy): migrate PostgreSQL protocol to pg-proto#443freshtonic wants to merge 7 commits into
freshtonic wants to merge 7 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the proxy PostgreSQL protocol implementation to published
pg-proto0.1.0 and remove the superseded local protocol stack.What changed
pg-protopg-protopg-protocodecsLegacy cleanup
Removed the handwritten frontend/backend tag enums, startup codes/messages, authentication wire model, ReadyForQuery and Terminate serializers, frame length/tag parsing, diagnostic serialization, and redundant Parse/Bind wire counts. The cleanup commit removes 1,251 lines while adding 296 lines of typed integration and retained policy.
Verification
cargo fmt --all -- --checkcargo clippy -p cipherstash-proxy --all-targets -- -D warningsCS_PROMETHEUS__ENABLEDunset: 127/127 unit tests pass, plus doc testsgit diff --checkFull Docker/TLS/COPY/asynchronous-message integration coverage has not yet been run.
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.