Conversation
The tools module's golden tests are not run by CI (make test covers src/ only) and had drifted from what the generator now emits. Regenerated with UPDATE_GOLDEN_FILES=1 so the next change can rely on them.
Paths whose entity segment contains a colon, such as /api/v1/config/dashboards:importFromClassic, are RPC-style verbs rather than CRUD entities. The generator took the segment verbatim as an entity name and then panicked in ScaffoldYAML because there is no schema to scaffold. clispec now ignores those paths entirely, so syncing a spec that carries them no longer breaks generation. Generated output for the current specs is unchanged.
bg451
force-pushed
the
bg451/chronoctl-sync-swagger-import-from-classic
branch
from
September 16, 2026 16:29
ad20670 to
bd8b7f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the hand-written
chronoctl dashboards import-from-classiccommand for the v1ImportDashboardFromClassicendpoint (POST /api/v1/config/dashboards:importFromClassic), which converts raw classic (Grafana) dashboard JSON into a Dashboard in one call.-f/--filenameis the raw classic dashboard JSON (not a chronoctl manifest), read whole and sent asclassic_dashboard_json;-reads stdin.--update-if-existswithout--slugis rejected client-side with the server's wording, so the user sees the error before a network call.v1/configDashboardmanifest (same shape asdashboards create/read), so it can be piped intodashboards update -f -or committed as config. It is printed on--dry-runtoo, as the preview.[LEVEL_UNSUPPORTED] <kind>: <message> (N occurrences; panels: a, b)). The API call succeeded, so the exit code stays 0; a--fail-on-unsupportedflag is left as a possible follow-up.The command lives in a new
src/cmd/pkg/dashboardspackage (the generator wipessrc/generated/cli, so hand-written commands cannot live there) and is attached to the generateddashboardscommand fromsrc/cmd/root.go. Unit tests coverrun()against the gomockconfigv1client (request body, YAML manifest, dry run, unsupported-feature rendering, wrapped API error), thevalidate()table, and the registration.Stacked PR. This branch is cut from and targets
bg451/chronoctl-sync-swagger-import-from-classic(#137), which brings in the generatedImportDashboardFromClassicclient this command calls. Read the diff on top of that one; when #137 merges this PR should be rebased onto its new base.claude: pr-lifecycle