knowledge: 3 insights — checksum-restored identifiers need a success-path warning (1 new page), delegated mutate-and-revert leaves stale .pyc (+1 merge), batch-wide domain rule dropped as superseded - #190
Open
choiyounggi wants to merge 1 commit into
Conversation
…rs, delegated mutate-and-revert stale pyc (1 superseded drop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowledge flush — 3 insight(s)
Claimed this run:
780cc9007d23bf67,01cc5fdd76565581,6db22c1e9830a187. Outcome: 1 new page, 1 amended page, 1 dropped (superseded).Verified best-practice
1.
01cc5fdd76565581— checksum-restored identifiers need a success-path warning → verified00123to123.dtypefor reading columns as strings.src/validation/tax_code.py, weights 31/29/23/19/17/13/7/5/3, check = 10 − (sum mod 11), remainder 0 rejected) against 200,000 seeded random0+9-digit inputs → 18,089 passed (9.04%); 200,000 random 10-digit inputs → 18,117 (9.06%). Matches the candidate's 18,242/200,000 and the analytic 1/11 ≈ 9.09%. Confirmed the originating fix exists at HEAD of the source repo (src/company_import.py:was_leading_zero_restored+ "restored … verify" warning).2.
6db22c1e9830a187— stale.pycafter a subagent's mutate-and-revert → verified (merged into an existing verified page)__pycache__before trusting the next suite run; CPython's default timestamp(+size) validation can reuse the mutant's bytecode.backend-python-language-bytecode-cache-staleness(docs.python.org import reference — "storing the source's last-modified timestamp and size"; PEP 552; py_compile; three prior field reproductions). The candidate's case ("n/a"→"N/A") is byte-length-preserving, so it falls exactly in the page's documented same-size/same-second window — consistent, no contradiction.last_verifiedleft unchanged (docs not re-fetched this run).3.
780cc9007d23bf67— evaluate per-row rejection rules against the whole batch's domain set → dropped (superseded / contradicted)b89f8c6, "write one extracted_contacts row per page in batch extraction", issue knowledge: LLM output-cap budgeting + verification-harness reverse controls (2 of 3 insights; 1 already in flight) #13), andtests/test_ai_extractor.py::test_extract_batch_email_domain_matching_no_batch_page_stays_validpins that batch-wide domain widening wrongly flags a row whose email matches a sibling page's domain — the exact directive this candidate proposes. The evidence paths cited in the candidate (.orchestration/archive-20260910-cv0910/reviews/…) no longer exist on disk. The directive as written is not a best-practice, so it is not ingested. (The salvageable idea — attribute each fanned-out result to its own source — would need its own candidate and sourcing.)Existing-layer check
Pages read: backend-python-language-bytecode-cache-staleness, testing-quality-mutation-harness-file-custody, backend-common-change-impact-aggregation-layer-of-a-shared-helper, databases-schema-design-column-data-types
Also read:
INDEX.md,wiki/backend/index.md,wiki/testing/index.md,wiki/qa/index.md,wiki/infrastructure/index.md(grep),wiki/security/index.md(grep); keyword sweep ofwiki/forpycache|.pyc|bytecode|checksum|leading zero|check digit|mod-11|fan-out|batch.bytecode-cache-stalenessalready owns the trigger and directive (purge__pycache__between edit iterations; "regression persists after a clean revert" Instead-of row). Same trigger, same directive → merged (edge row + source), no new page.mutation-harness-file-custodyis adjacent (restore custody, not cache) and already linked throughharness-reverse-controls; no change needed.column-data-typesonly states "national ids → TEXT, leading zeros are data" (storage side). → new pagebackend-common-integrations-checksum-restored-identifiers;related:todatabases-schema-design-column-data-types,backend-common-integrations-consumer-required-fields,security-input-validation-at-trust-boundaries; backlink added oncolumn-data-types.aggregation-layer-of-a-shared-helper(same helper in two aggregation layers) — different trigger; no conflict to flag because the candidate was dropped.Open-PR check
Listed open heads (
gh pr list --search "head:knowledge/"): #189knowledge/choiyounggi-20260910-162026, #188…-20260908-154412, #187…-20260906-213635, #186…-20260906-013856, #185…-20260906-003745, #183…-20260904-133717, #182…-20260903-214027, #181…-20260903-203836, #180…-20260903-184706, #179…-20260903-172728.For each:
git fetch origin <head>thengit diff origin/main...origin/<head> -- wiki/, scanning the changed-file list for the target pages and the added lines forpycache|.pyc|bytecode|leading zero|checksum|check digit|fan-out|per-row|batch.bytecode-cache-staleness.mdorcolumn-data-types.md. Keyword hits were unrelated (GIL bytecode switching in knowledge: 6 insights — gate EVIDENCE exit-code class (unset CLAUDE_PLUGIN_ROOT), jq.rebinding in predicates, worker-reported plan contradiction, benchmark speedup attribution, sequential-dispatch test under a thread pool, lock-protection race-window test (6 new pages, 0 merges, 0 drops) #189, per-row reorder locking in knowledge: 8 insights — OKLCH dark-surface steps, benchmark-relative signals, multi-row reorder concurrency, Prisma CONCURRENTLY, graphify viz failure, newest-transcript measurement, fake-timer TTL isolation, fallback-source alert (+3 folds onto #179/#181, 1 already-merged drop) #185, batch screenshots in knowledge: 12 insights — sequential ids across parallel workers, inbound-validation task ownership, vendor benchmark claims, element crop screenshots, WebFetch summary vs raw page, Steps-prose guarantees, split fact-check verdicts (+4 folds, 1 dup) #182, queued-row retirement in knowledge: 8 insights — SwiftPM executable-target tests, off-screen macOS capture without Screen Recording, Testcontainers reaper on Docker Desktop, ciphertext orphaned by a regenerated key, model-coupled guidance aging detector, CORS preflight probe silence, queued-candidate store check, literal-constant re-assertion (+3 folds onto #181, 1 pending-duplicate drop) #186).backend/common/integrations/contact-details-from-scraped-pages.md(same category as the new page, different trigger: main-content scrapers dropping contact regions); knowledge: 8 insights — OKLCH dark-surface steps, benchmark-relative signals, multi-row reorder concurrency, Prisma CONCURRENTLY, graphify viz failure, newest-transcript measurement, fake-timer TTL isolation, fallback-source alert (+3 folds onto #179/#181, 1 already-merged drop) #185/knowledge: 12 insights — workflow file that registers no triggers, workflow-authored PRs (create-PR setting, personal-repo ruleset, GITHUB_TOKEN checks, --auto), Firecrawl main-content vs contact details, testcontainers community namespace, pointer-attracted particle collapse, producer wire format in mocks (+5 merges incl. Homebrew clang SDKROOT contradiction reconciled) #187 addintegrations/rows tobackend/index.md— row-level index edits, no content overlap.01cc5fdd76565581→ new;6db22c1e9830a187→ new (merge into an existing main-branch page, no open PR carries it);780cc9007d23bf67→ not ingested (dropped on verification, no open PR carries it either).Routing decision
01cc5fdd76565581wiki/backend/common/integrations/checksum-restored-identifiers.mdbackend/index.mdintegrations row + backlink ondatabases/schema-design/column-data-types6db22c1e9830a187wiki/backend/python/language/bytecode-cache-staleness.md780cc9007d23bf67No new category.
integrationswas chosen oversecurity/inputbecause the concern is repair and provenance of values from an external file format, not trust-boundary rejection. It was chosen overdatabases/schema-designbecause the loss happens before storage.