Skip to content

ci: move the release toolkit to v5.0.0 and the App client ID #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chhoumann merged 1 commit into from
Oct 24, 2026
Merged

ci: move the release toolkit to v5.0.0 and the App client ID #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release-prepare.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
permissions:
contents: write
pull-requests: write
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release-prepare.yml@149e37801b35c120660a1fd5e78a5471fda55726 # v4.1.0
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release-prepare.yml@d6b3b8c2cf460059238043b32a08dcaa3be4828f # v5.0.0
with:
plugin-name: podnotes
package-manager: npm
Expand All @@ -56,7 +56,7 @@ jobs:
node-version: "22"
target-sha: ${{ github.event.workflow_run.head_sha || inputs.targetSha }}
release-bot-app-slug: podnotes-release-bot
app-id: ${{ vars.RELEASE_APP_ID }}
client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
dry-run: ${{ inputs.dryRun == true }}
secrets:
release-app-private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/release-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
actions: write
contents: write
pull-requests: read
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release-validate.yml@149e37801b35c120660a1fd5e78a5471fda55726 # v4.1.0
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release-validate.yml@d6b3b8c2cf460059238043b32a08dcaa3be4828f # v5.0.0
with:
pr-number: ${{ github.event.pull_request.number || inputs.pr-number }}
plugin-name: podnotes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
contents: write
id-token: write
pull-requests: read
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release.yml@149e37801b35c120660a1fd5e78a5471fda55726 # v4.1.0
uses: chhoumann/obsidian-plugin-workflows/.github/workflows/release.yml@d6b3b8c2cf460059238043b32a08dcaa3be4828f # v5.0.0
with:
release-pr: ${{ inputs.releasePr }}
plugin-name: podnotes
Expand Down
6 changes: 3 additions & 3 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ when the GitHub release is public, its tag points at the release commit, and
`main.js` and `manifest.json` match their recorded SHA-256 digests.

Three workflows in `.github/workflows/` call reusable workflows in
`chhoumann/obsidian-plugin-workflows` pinned to v4.1.0
(`149e37801b35c120660a1fd5e78a5471fda55726`):
`chhoumann/obsidian-plugin-workflows` pinned to v5.0.0
(`d6b3b8c2cf460059238043b32a08dcaa3be4828f`):

1. `Prepare release` (`release-prepare.yml`) runs after a green `Test` push run
on `master`, or by `workflow_dispatch` with an optional `targetSha`. It skips
Expand Down Expand Up @@ -365,7 +365,7 @@ When a feature requires a newer Obsidian API, raise `manifest.json`
unchanged. The floor can only go up, and the release PR records it under the
new version.

Setup: install the `podnotes-release-bot` App with the `RELEASE_APP_ID`
Setup: install the `podnotes-release-bot` App with the `RELEASE_APP_CLIENT_ID`
variable and the `RELEASE_APP_PRIVATE_KEY` secret. The default `GITHUB_TOKEN`
stays read-only. The pipeline writes only `release/*` and `release-run/*`
branches and tags, never `master`, so the master ruleset needs no bypass actor.
Expand Down
Loading