Skip to content

Parametrized Google Tests for Keccak - #233

Open
illiashkirko wants to merge 2 commits into
chfast:masterfrom
illiashkirko:master
Open

Parametrized Google Tests for Keccak#233
illiashkirko wants to merge 2 commits into
chfast:masterfrom
illiashkirko:master

Conversation

@illiashkirko

Copy link
Copy Markdown

This pull request adds a parametrized Google Test for the Keccak unit tests, enabling the specification of the input size via command line parameters. It also includes an extended bytes test, covering a range of input sizes from 128 to 2048. The input data is generated deterministically to ensure consistent results. These updates improve the Keccak test suite, enhancing coverage and validating the algorithm's behavior effectively.

@illiashkirko
illiashkirko force-pushed the master branch 4 times, most recently from cb3e753 to f5bc0ae Compare September 1, 2023 18:47
@chfast

chfast commented Sep 10, 2023

Copy link
Copy Markdown
Owner

Hi @illiashkirko, sorry you had to wait. Can you rebase your PR (I just fixed CI builds)?

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.68%. Comparing base (17e8030) to head (f8f5b86).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   98.65%   98.68%   +0.03%     
==========================================
  Files          17       17              
  Lines        1337     1371      +34     
==========================================
+ Hits         1319     1353      +34     
  Misses         18       18              
Flag Coverage Δ
be 85.72% <100.00%> (+0.36%) ⬆️
default 98.45% <100.00%> (+0.03%) ⬆️
x86_64 85.40% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/unittests/test_keccak.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants