Skip to content

keccak init-update-final api - #229

Open
rodiazet wants to merge 3 commits into
masterfrom
228-implement-init-update-final-api-for-keccak
Open

keccak init-update-final api#229
rodiazet wants to merge 3 commits into
masterfrom
228-implement-init-update-final-api-for-keccak

Conversation

@rodiazet

Copy link
Copy Markdown
Collaborator

Implementation of new keccak interface supporting init-update-final access model.

@rodiazet rodiazet linked an issue Oct 29, 2022 that may be closed by this pull request
@rodiazet
rodiazet requested a review from chfast October 29, 2022 07:13
@rodiazet
rodiazet force-pushed the 228-implement-init-update-final-api-for-keccak branch from e213a86 to f061fee Compare November 4, 2022 12:56
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.39655% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.00%. Comparing base (dfc8d08) to head (f061fee).
⚠️ Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
lib/keccak/keccak.c 90.84% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   98.65%   98.00%   -0.66%     
==========================================
  Files          17       17              
  Lines        1335     1550     +215     
==========================================
+ Hits         1317     1519     +202     
- Misses         18       31      +13     
Flag Coverage Δ
be ?
default 97.80% <94.39%> (-0.61%) ⬇️
x86_64 86.38% <94.39%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/ethash/keccak.hpp 100.00% <100.00%> (ø)
test/unittests/test_keccak.cpp 100.00% <100.00%> (ø)
lib/keccak/keccak.c 96.64% <90.84%> (-3.36%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Init-Update-Final API for Keccak

1 participant