Repository navigation
fix(wear): declare AD_ID in the Wear OS manifest; publish workflow builds the Wear bundle - #32
Conversation
…ilds the Wear bundle too Play Console blocks releases when any active artifact of com.charles.dosely lacks com.google.android.gms.permission.AD_ID while the Advertising ID declaration says the app uses it (the phone app does: AdMob banners, declared directly and via play-services-ads). The Wear bundle (versionCode 3) had no AD_ID, so every production release showed the error. - wear/AndroidManifest.xml: add the AD_ID permission (the watch app shows no ads) - Publish workflow: version_code (phone) and wear_version_code (Wear OS) are each optional; the Wear bundle is built with :wear:bundleRelease, signed with the same keystore and uploaded to the wear:<track> form-factor track; both AABs are kept as run artifacts
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b641f1ac59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| serviceAccountJsonPlainText: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }} | ||
| packageName: com.charles.dosely | ||
| releaseFiles: wear/build/outputs/bundle/release/wear-release.aab | ||
| track: wear:${{ github.event.inputs.track }} |
There was a problem hiding this comment.
wear:qa
When a Wear version is supplied while the workflow's default internal track remains selected, this produces wear:internal, so r0adkll/upload-google-play rejects it during its exact track-name validation and the Wear release is not uploaded (after the phone upload may already have committed). Google defines the Wear OS internal-testing track as wear:qa, while wear:internal would only exist if a custom closed track with that name had been created; map the internal choice to qa when constructing the Wear track. See Google's form-factor track-name table and the action's track validation.
Useful? React with 👍 / 👎.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by free · Input: 127.2K · Output: 3.3K · Cached: 13K |
Play Console blocks production releases of
com.charles.doselywith "A manifest file in one of your active artifacts doesn't include the com.google.android.gms.permission.AD_ID permission" because the Advertising ID declaration is Yes (advertising/marketing) — true for the phone app (AdMob banners;AD_IDis declared inapp/AndroidManifest.xmland also merged in byplay-services-ads) — while the Wear OS bundle (versionCode 3) had noAD_ID.Changes
wear/src/main/AndroidManifest.xml: declarecom.google.android.gms.permission.AD_ID(the watch app shows no ads; this keeps every artifact consistent with the declaration)version_code(phone) and newwear_version_code(Wear OS) are each optional — the Wear bundle is built with:wear:bundleRelease, signed with the same keystore, verified, and uploaded to thewear:<track>form-factor track; both AABs are kept as run artifactsNext: build + upload Wear 1.1.1 (versionCode 5) to
wear:productionand add it to the release in review, replacing versionCode 3.