Skip to content

fix(site): refresh branding and stabilize playground reports - #509

Merged
cevdetch merged 3 commits into
mainfrom
site/brand-playground-20261019
Oct 19, 2026
Merged

cevdetch merged 3 commits into
mainfrom
site/brand-playground-20261019

Conversation

@cevdetch

Copy link
Copy Markdown
Owner

Summary

The playground inserts its first report above a visible desktop footer, producing a reported CLS of 0.329. Reserve a viewport of report space from the first paint while retaining automatic reports for the example, shared links and bookmarklets. Long reports grow in normal page flow.

Rename the output to “HTML after automatic fixes”, use “Copy HTML”, and report fixes alongside the actual remaining findings. The default example now explains its result as “3 automatically fixed · 2 remaining”; each finding indicates automatic or manual handling.

Install the generated leaf-green/shared-gold logo assets in a separate commit. Use the static SVG favicon and update the manifest colours and maskable icon purposes. Preserve the existing page accents and keep theme colour in the manifest. A third commit corrects README statements about adapter agreement, the bookmarklet's source fetch and Node 24.8.

Validation

  • Rule validation, rule/CSS/bookmarklet builds, all three TypeScript checks and self-lint passed with Node 24.
  • All 14 focused playground tests passed, including fixture parity, the demo's three fixes/two remaining findings, automatic startup for all entry points, and clipboard/file error recovery.
  • Astro check: 40 files, zero errors/warnings/hints. Site build, HTML lint and SEO passed across 249 pages.
  • Unchanged size budgets passed: /try HTML 1,985/2,000 gzip bytes; script closure 82,625/82,640 gzip bytes; global CSS 3,997/4,000 raw bytes.
  • Palette registry check and icon generation passed; installed assets/tokens match generator output. The 16px preview was inspected.
  • All three binary patches apply cleanly to the reviewed main commit and recreate tree 0f258e9ae0c17e81891c1fda447860c704e2e254.
  • Earlier full-suite attempt: 791 passed and 90 failed, with denied child-process/server operations and dependent assertions in the restricted environment. This is not a green full-suite result. Branding tool tests also encountered child-process EPERM. Rerun the standard checks in an unrestricted session before committing.

Notes for the reviewer

Actual browser CLS/PageSpeed validation is pending: Chromium could not launch in this environment. Check both form factors, shared HTML, bookmarklet reports and slow loading. Minimum reserved space targets the reported initial footer shift; scrolling to the footer before a very slow report finishes can still expose movement. Short reports retain the reserved space.

No rule behaviour, package version, published package or UI palette was changed. No additional theme-color meta tag was added.

Install the generated leaf-green and shared-gold icon set. Use the static SVG
for the favicon, retain the animated header mark, and update the manifest
colours and maskable icon purposes. Keep theme colour in the manifest.
Reserve report space before client linting fills the page, preserving automatic
example, shared-link and bookmarklet reports. Let long reports grow normally.
Label the output as HTML after automatic fixes and report both applied fixes
and remaining findings from the final analysis. Mark manual findings explicitly.
Qualify adapter agreement for source-dependent capabilities, describe the
bookmarklet full-report fetch, and state the Node 24.8 minimum for clone work.
@cevdetch
cevdetch marked this pull request as ready for review October 19, 2026 22:12
@cevdetch
cevdetch merged commit 506c8eb into main Oct 19, 2026
7 checks passed
@cevdetch
cevdetch deleted the site/brand-playground-20261019 branch October 19, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant