Repository navigation
fix(build): match helper imports literally - #508
Merged
Merged
Conversation
Escape helper export names and module filenames in the usage check, and recognize dollar signs as part of JavaScript identifiers. Add regressions for complete identifiers and literal module filenames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared-helper usage validator treats dollar signs in exported names and
punctuation in module filenames as regex syntax. This can mark imported names
unused and unrelated names or modules used. Escape both values and match full
JavaScript identifiers, including dollar signs.
Two regression tests cover imported and unimported dollar-sign names, literal
filename periods and a filename containing a plus sign. Both tests failed before
the fix and pass with it.
Validation
Verified on Node 24.21.0 with the pinned pnpm 12.6.0:
pnpm install --frozen-lockfilenode --test --test-name-pattern=checkLibModules test/rules.test.ts— 3 passedpnpm validate:rules && pnpm build && pnpm build:css && pnpm build:bookmarklet && pnpm typecheck && pnpm test && pnpm check:self— 877 tests passedpnpm site:check && pnpm check:site— 249 pages pass lint, size and SEO checkspnpm check:packages && pnpm smoke:packages— package and consumer checks passpnpm lint:deps— exit zero, 45 warningsgit diff --checkNotes for the reviewer
This changes the build-time helper import check. The regression cases exercise
its observable diagnostics using temporary module files.