docs(thirdweb): collapse seven thirdweb pages into one tool page at parity (#2255) - #2291
Conversation
palango
left a comment
There was a problem hiding this comment.
Ran the checks myself on this branch and they match the PR body: broken-links is green, the orphan count is down to 20 with the three thirdweb ones gone. All seven old paths reach the new page in one hop, and nothing in mdx/jsx still points at the deleted pages or images.
-
The Celo Sepolia claim in the new page is wrong.
tooling/dev-environments/thirdweb.mdx:13says there's no named export for Celo Sepolia, but thirdweb@5.121.1 exportsceloSepoliaTestnetfromthirdweb/chains, chain ID 11142220.defineChain(11142220)does work, so nothing is broken today, but this page's whole job is the Celo chain config:import { celo, celoSepoliaTestnet } from "thirdweb/chains";
-
Add a redirect for
/tooling/libraries-sdks/thirdweb-sdk/index. Mintlify served the deleted page at that path too, and right now only the bare path is covered, so the/indexvariant will 404. docs.json already has 29/indexsources for this case. -
Not from this PR, no need to fix here: the
mdx-code-blockfence attooling/dev-environments/index.mdx:29is a Docusaurus/Crowdin leftover that Mintlify renders as a literal code block. You're editing right below it anyway, so feel free to drop the fence, or leave it for a cleanup pass.
|
All three addressed in 1. The Celo Sepolia claim was wrong. Confirmed against the published package rather than taking it on trust:
2. 3. Fence dropped. Removed the
|
…arity (#2255) thirdweb was documented across seven pages — a group of three under Dev Environments, an SDK page under Libraries & SDKs, and three orphaned pages under build-on-celo/ — with tutorials, step-by-step code, and "recommended" wording that no other tool in the docs gets. It is now one page, `tooling/dev-environments/thirdweb`, flat alongside foundry, hardhat and remix: what it is, the Celo chain configuration, and a link to thirdweb's own docs. All six other paths redirect there. Also in this change: - Removes the tutorials (NFT drop, one-click quickstart) and the CLI/SDK walkthroughs — thirdweb's own docs cover them. - Wallet-provider entry in tooling/wallets/index kept as a plain list item at parity with the other providers; utm campaign parameters dropped there and on the nodes page. - x402 "Alternative: thirdweb facilitator" reduced to one link under a neutral "Other facilitators" heading. - Indexer section of scaling-your-app no longer recommends a vendor; it points at the Indexers group. - Fixes a mislinked wagmi reference in attribution-tags that pointed at the thirdweb overview page. - Updates the two stale "Using ..." lists to current root-relative paths and adds the missing Foundry entry. - Deletes three now-unreferenced thirdweb images. Clears the three thirdweb orphans; the remaining 20 belong to #2253. Verified: `mintlify broken-links` reports no broken links; `scripts/check-orphans.sh` reports 20 orphans, all owned by #2253. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…irect Review fixes on #2255: - `thirdweb/chains` does export Celo Sepolia as `celoSepoliaTestnet` (chain ID 11142220). Verified against thirdweb@5.121.1: dist/esm/chains/chain-definitions/celo-sepolia-testnet.js. The page now uses the named export for both networks instead of defineChain. - Adds the `/tooling/libraries-sdks/thirdweb-sdk/index` redirect source. Mintlify served the deleted page at that path too, and only the bare path was covered. - Drops the `mdx-code-block` fence in tooling/dev-environments/index.mdx — a Docusaurus/Crowdin leftover that Mintlify renders as a literal code block. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
6c3fb63 to
c4ec6d1
Compare
Closes the code half of #2255.
What changed
thirdweb was documented across seven pages — three under Dev Environments (
overview,thirdweb,one-click-deploy), an SDK page under Libraries & SDKs, and three orphaned pages underbuild-on-celo/build-with-thirdweb/— with tutorials, step-by-step code, and wording no other tool gets ("Using Thirdweb is recommended because…", "Complete Web3 development framework with powerful wallet tools", "Recommended: Use affordable indexers like thirdweb Insight").It is now one page:
tooling/dev-environments/thirdweb, flat alongsidefoundry.mdx,hardhat.mdxandremix.mdx, same title pattern ("Deploy on Celo with thirdweb" / sidebar "Using thirdweb"). It carries only what these docs actually own — the Celo chain configuration — and points at thirdweb's own docs for the rest.Resolving the ticket's OPEN question
Dev Environments. Foundry, Hardhat and Remix are single flat
.mdxfiles in that group; a single page in its own folder next to them would not match. All seven old paths redirect to the one page.De-promotion pass on the remaining mentions
tooling/wallets/index.mdxutm_source=celo&utm_medium=documentation&utm_campaign=chain_docsdropped (no other provider carries campaign parameters)build-on-celo/build-with-ai/x402.mdxbuild-on-celo/scaling-your-app.mdx/tooling/indexers/overviewtooling/libraries-sdks/web3/index.mdxtooling/nodes/overview.mdxbuild-on-celo/quickstart.mdxTwo unrelated bugs fixed while in these files
build-on-celo/attribution-tags.mdx:64linked wagmi to/tooling/dev-environments/thirdweb/overview. Now points atwagmi.sh.tooling/overview/index.mdxandtooling/dev-environments/index.mdxboth listed/developer/deploy/*(stale redirect sources) and omitted Foundry. Both lists are now current root-relative paths, alphabetical, with Foundry added.Three now-unreferenced images deleted (
img/thirdweb.svg,img/thirdweb-explore.png,img/building/how-to-deploy/thirdweb/thirdweb-explore.png) —grepacross*.mdx,*.jsonand*.jsxshows no remaining references.On the redirect chain
The ticket flagged a chain at
docs.json:1468→/build/build-with-thirdweb/celo-nft-drop-tutorial, itself a redirect source. That dead end was already pruned by #2279. Verified on this branch — no thirdweb redirect resolves to another redirect source:Verification
20, down from 23 — the three thirdweb orphans are gone. The remaining 20 are #2253's, and #2253 stacks on this branch so the orphan check can flip from report-only to gating in one step.
Not in this PR
The ops half of #2255 is untouched and the issue should stay open for it: the usage audit of which ecosystem projects still rely on thirdweb, notifying the top projects, and planning the vendor move. Nothing in this repo can answer that.
The thirdweb title pair from #2241 is resolved as a side effect — the colliding "Overview"/"Getting Started with Thirdweb" pages no longer exist.