Plat 11963 modular instances dont move

[Ikreb1]

fix for https://fenriscreations.atlassian.net/browse/PLAT-11963 which forgot to move the instances

also snuck in evechildpartdata chaining to the root object so graphite doesnt complain about missing name attribute

[Copilot]

Pull request overview

Fixes PLAT-11963 by ensuring modular-part transform edits propagate to instanced-mesh children, and updates Blue exposure so EveChildPartData chains to its base (avoiding missing name complaints).

Changes:

• Update EveModularObjectModifier::SetTransform() to also update transforms for EveChildInstancedMeshes instances with the edited partTag.
• Add utilities to EveInstancedMeshManager::StaticPerInstanceData (SetTransform() / ToMatrix()) and refactor instanced-mesh code to use them.
• Add a Blue-exposed Python API GetInstancesTransforms(meshId) for inspecting per-instance SRT transforms.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
trinity/Eve/SpaceObject/Children/EveModularObjectModifier.cpp	Propagates part transform changes into instanced mesh instances.
trinity/Eve/SpaceObject/Children/EveChildPartData_Blue.cpp	Chains Blue exposure to EveSpaceObjectChild to inherit base attributes (e.g., name).
trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.h	Declares new instance-transform setter and Python inspection API.
trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp	Implements partTag-based instance transform updates; adds transform inspection; refactors matrix handling.
trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes_Blue.cpp	Exposes GetInstancesTransforms to Blue/Python.
trinity/Eve/EveInstancedMeshManager.h	Adds StaticPerInstanceData helpers for transform conversion.
trinity/Eve/EveInstancedMeshManager.cpp	Implements StaticPerInstanceData::SetTransform() and ToMatrix().

Suppressed comments (1)

trinity/Eve/SpaceObject/Children/EveChildInstancedMeshes.cpp:1078

• wt is declared but no longer used after switching to ToMatrix(), which will trigger an unused-variable warning (and can break builds if warnings are treated as errors). Remove the variable.

			const auto& wt = mesh.instances[i].worldTransform;
			OverlayInstancePod& pod = ( *mesh.overlayPods )[i];

			Matrix local = mesh.instances[i].ToMatrix();

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.