Switch to using v145 as the default compiler for Windows - #71
Draft
filipppavlov wants to merge 2 commits into
Draft
Switch to using v145 as the default compiler for Windows#71filipppavlov wants to merge 2 commits into
filipppavlov wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows build configuration to default to the v145 toolset and applies a few code tweaks to eliminate compile errors/warnings that show up under the newer compiler/toolchain.
Changes:
- Switch Windows CMake presets (toolchain + vcpkg triplets) to
-145-*variants. - Update TeamCity Windows build bootstrap parameters to prefer the v145 toolset via
VS_DEV_BAT_SWITCHES. - Fix a handful of C++ compile warnings/errors (HRESULT-sized return types and
powfloat overload selection).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
trinity/Tr2RenderTarget.h |
Changes GenerateMipMaps/Resolve return type to int32_t for toolchain compatibility. |
trinity/Tr2RenderTarget.cpp |
Updates implementations to match the new int32_t signatures. |
trinity/Tr2DepthStencil.h |
Changes Create return type to int32_t. |
trinity/Tr2DepthStencil.cpp |
Updates implementation signature to match header. |
trinity/Eve/SpaceObject/EveMissileWarhead.cpp |
Adjusts pow call to use float exponent (2.f) to avoid float/double warnings. |
trinity/Eve/SpaceObject/Children/EveChildCloud2.cpp |
Adjusts pow call to use float exponent (3.f) to avoid float/double warnings. |
CMakePresets.json |
Switches Windows chainload toolchain + vcpkg triplets to -145- variants. |
.teamcity/Windows/Project.kt |
Changes Windows build parameters to default VS_DEV_BAT_SWITCHES to a v145-oriented -vcvars_ver. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
|
|
||
| class CarbonBuildWindows(buildName: String, configType: String, preset: String) : BuildType({ | ||
| class CarbonBuildWindows(buildName: String, configType: String, preset: String, vsDevBatSwitches: String = "-arch=x64 -vcvars_ver=14.51") : BuildType({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMakePresets.json and TC config to use v145 compiler when building for Windows; fix compile errors/warnings when building with v145