Add type annotations to functions in hostname.py - #6964
Open
XEDAB wants to merge 3 commits into
Open
Conversation
Collaborator
|
Thank you for this contribution, To aid the majority of readers in this repository, could you please ensure the proposed commit message and summary is in English. |
Author
|
Sorry, will fix the commit message and PR title to English. |
XEDAB
changed the title
Author
|
PR description updated to English. |
Member
|
Please sign the CLA. Also, please don't forget to remove this module from mypy's ignore list in pyproject.toml. It also looks like there are failing unit tests and lint tests. Please review the contribution guide: https://docs.cloud-init.io/en/latest/development/index.html |
str | None needs Python 3.10+. Optional[str] is the 3.9-safe equivalent. Also remove hostname.py from the mypy ignore list now that it carries full annotations.
holmanb
added
the
CLA not signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type annotations (parameter types and return types) to all functions in hostname.py, so a reader can tell at a glance what each function expects and returns.