Skip to content

fix(ag-ui): isolate child reasoning with real HTTP lifecycle coverage - #1161

Merged
blove merged 2 commits into
mainfrom
codex/ag-ui-child-delivery
Sep 24, 2026
Merged

blove merged 2 commits into
mainfrom
codex/ag-ui-child-delivery

Conversation

@blove

@blove blove commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Attributed AG-UI reasoning events currently enter the parent reducer, so a child can contaminate the parent transcript and replace its reasoning timer. Route child reasoning into the existing child message projection, preserving its answer and tool links. Reject inactive, foreign, settled and terminal-child events before changing ownership; reasoning END remains inert.

Retain seven real HTTP/SSE regressions through the locked HttpAgent and actual adapter: successful completion, incomplete stream closure, server error, physical stop/dispose cancellation, sequential run isolation, and parent/two-child reasoning. These verify terminal evidence and physical connection closure rather than treating a resolved SDK promise as success.

Validation:

  • 456 AG-UI tests across 24 files; public type checks and strict compilation of the HTTP spec.
  • Production build; lint with zero errors and 317 warnings (including non-null assertions in the new callback/reducer tests); inventory, source boundaries, version consistency and diff checks.
  • Independent compliance and quality reviews plus parent verification.
  • Semantic negative controls reproduce parent contamination and detect removal of explicit request abort; production source restored before final checks.
  • Automated browser flows and Chrome MCP/in-app-browser walkthroughs cover the actual adapter with controlled events and, separately, actual local SSE through HttpAgent. Consoles were clean.

Wire coverage uses distinct message IDs: the locked SDK rejects simultaneous same-ID reasoning across lanes before adapter reduction. Same-ID reducer/callback tests establish decoded-source isolation. This change adds no public API, dependency upgrade or release and does not claim neutral AG-UI package or production React UI parity.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 24, 2026 8:37pm UTC

Request Review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove enabled auto-merge (squash) September 24, 2026 20:35
@blove
blove merged commit d318726 into main Sep 24, 2026
77 of 78 checks passed

This branch was successfully deployed

1 active deployment
Preview – threadplane — 3a50f98a Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant