Skip to content

fix(libs): pin the type-tests compiler; document the tsconfig baseUrl blocker #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 2 commits into from
Sep 8, 2026
Merged

fix(libs): pin the type-tests compiler; document the tsconfig baseUrl blocker #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b1bf0
fix(libs): run the type-tests targets on the workspace TypeScript
blove Sep 8, 2026
1b092e6
docs(workspace): record why tsconfig baseUrl cannot be dropped yet
blove Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/ag-ui/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"type-tests": {
"executor": "nx:run-commands",
"options": {
"command": "npx tsc --noEmit -p libs/ag-ui/tsconfig.type-tests.json"
"command": "node ./node_modules/typescript/bin/tsc --noEmit -p libs/ag-ui/tsconfig.type-tests.json"
}
},
"prepare-install": {
Expand Down
3 changes: 0 additions & 3 deletions libs/ag-ui/tsconfig.type-tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"extends": "./tsconfig.lib.json",
"compilerOptions": {
"noEmit": true,
// This target runs the workspace `tsc` (newer than the build compilers),
// which errors on the inherited baseUrl unless deprecations are ignored.
"ignoreDeprecations": "6.0",
// Type-specs import sibling libraries through tsconfig paths; with noEmit
// the rootDir only has to be wide enough to contain them.
"rootDir": "../..",
Expand Down
2 changes: 1 addition & 1 deletion libs/chat/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"type-tests": {
"executor": "nx:run-commands",
"options": {
"command": "npx tsc --project libs/chat/tsconfig.type-tests.json --noEmit"
"command": "node ./node_modules/typescript/bin/tsc --project libs/chat/tsconfig.type-tests.json --noEmit"
}
},
"prepare-install": {
Expand Down
3 changes: 0 additions & 3 deletions libs/chat/tsconfig.type-tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
"compilerOptions": {
"outDir": "../../dist/out-tsc/type-tests",
"noEmit": true,
// This target runs the workspace `tsc` (newer than the build compilers),
// which errors on the inherited baseUrl unless deprecations are ignored.
"ignoreDeprecations": "6.0",
// Type-specs import sibling libraries through tsconfig paths; with noEmit
// the rootDir only has to be wide enough to contain them.
"rootDir": "../..",
Expand Down
2 changes: 1 addition & 1 deletion libs/langgraph/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"type-tests": {
"executor": "nx:run-commands",
"options": {
"command": "npx tsc --noEmit -p libs/langgraph/tsconfig.type-tests.json"
"command": "node ./node_modules/typescript/bin/tsc --noEmit -p libs/langgraph/tsconfig.type-tests.json"
}
},
"prepare-install": {
Expand Down
3 changes: 0 additions & 3 deletions libs/langgraph/tsconfig.type-tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"extends": "./tsconfig.lib.json",
"compilerOptions": {
"noEmit": true,
// This target runs the workspace `tsc` (newer than the build compilers),
// which errors on the inherited baseUrl unless deprecations are ignored.
"ignoreDeprecations": "6.0",
// Type-specs import sibling libraries through tsconfig paths; with noEmit
// the rootDir only has to be wide enough to contain them.
"rootDir": "../..",
Expand Down
9 changes: 9 additions & 0 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@
"noImplicitOverride": true,
"noImplicitReturns": true,
"noUnusedLocals": true,
// TypeScript 7 drops `baseUrl`, and since TypeScript 5.0 the `paths` below
// no longer need it (they resolve against this file's directory). It cannot
// go yet: Nx's buildable-library executors (`@nx/angular:package`,
// `@nx/js:tsc`) write a generated tsconfig under `tmp/<projectRoot>/build/`
// that re-declares `paths` with workspace-root-relative dist outputs such as
// `dist/libs/telemetry/browser`. Those entries are non-relative, so without a
// `baseUrl` TypeScript reports TS5090 and discards the whole `paths` map,
// and every library that depends on another library fails to compile.
// Removing this needs an Nx fix (or the Nx TS-solution setup) first.
"baseUrl": ".",
"paths": {
"@threadplane/design-tokens": ["libs/design-tokens/src/index.ts"],
Expand Down
Loading