Skip to content

feat(chat): public scrollToBottom() on ChatComponent; the stage pins through it - #1045

Merged
blove merged 1 commit into
mainfrom
blove/chat-scroll-to-bottom
Sep 7, 2026
Merged

feat(chat): public scrollToBottom() on ChatComponent; the stage pins through it#1045
blove merged 1 commit into
mainfrom
blove/chat-scroll-to-bottom

Conversation

@blove

@blove blove commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

The scroll-to-bottom bubble's logic is promoted to a public method so hosts
that apply many messages in one pass (the stage replay seeking to a recorded
time) can re-pin once their layout settles, with the write counted as
programmatic so the chat's own scroll handler does not read it as the user
unpinning. StageMode drops its querySelector on the private .chat-scroll
class and calls the method through a view child.

Follow-up 5 from the homepage live-stage arc. Tests: chat component spec 59/59 (new case: scrolls to the end, re-pins, and the programmatic scroll does not unpin), stage component spec 9/9 unchanged, api-docs regenerated.

🤖 Generated with Claude Code

…through it

The scroll-to-bottom bubble's logic is promoted to a public method so hosts
that apply many messages in one pass (the stage replay seeking to a recorded
time) can re-pin once their layout settles, with the write counted as
programmatic so the chat's own scroll handler does not read it as the user
unpinning. StageMode drops its querySelector on the private .chat-scroll
class and calls the method through a view child.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
threadplane Ready Ready Preview Sep 7, 2026 2:26am UTC

Request Review

@blove
blove enabled auto-merge (squash) September 7, 2026 02:23

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval: this PR received an intelligent (AI) code review. See the review comments on this PR.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @blove's task in 0s —— View job


I'll analyze this and get back to you.

@blove
blove merged commit d30fd1e into main Sep 7, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant