Repository navigation
Never build from a language server start, lock installs, refuse shim links - #3
Merged
Merged
Conversation
… to link a shim A missing pinned version no longer starts a source build from burn lsp; the server uses the default version and says what to install. Installs of the same version cannot run at the same time. burnup link rejects a folder whose burn is a burnup shim, which would make burnup run itself forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the burnup paths that can exhaust a machine:
burn lsp/burn-lspran in a project pinned to a missing version, it started an optimized source build of Burn (several GB of RAM). If the editor restarted the server, several builds ran at once. Now the server uses the default version and prints which version to install.burnup linkrefuses a folder whosebin/burnis a burnup shim, because burnup would then run itself forever.The end-to-end tests cover all three, and pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PCXUjgpGnka9y7AHKfnN3w
Generated by Claude Code