fix(tests): CI-safe timing threshold for partial-cache latency test - #982
Merged
Merged
Conversation
… timing threshold CI's Python / Test (Max Versions) (3.13) job failed on main (run 36148490455) with initial_time=0.758s against a 0.5s bound. The assertion measures wall-clock widget-construction time, which is sensitive to shared-runner scheduling variance rather than the cache behavior itself - locally the same path consistently finishes in well under 0.1s. No file_cache logic changed between the last green Checks run and this one, so the failure isn't a regression. Widen the bound to 3.0s, matching the CI_TIMEOUT headroom this test directory already uses for the same class of scheduling-bootstrap variance (mp_test_utils.py). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.8.dev36458802452or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.8.dev36458802452MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.15.8.dev36458802452" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table📖 Docs preview🎨 Storybook preview |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python / Test (Max Versions) (3.13)job failed onmain(run 36148490455):test_huge_dataframe_partial_cache_scenarioassertedinitial_time < 0.5and got0.7584092617034912.mp_timeoutcalibration, is paid by an earlier test in the same file and was already warm by the time this test ran).Checksrun and the failing one touchedbuckaroo/file_cache/or the widget construction path, so this isn't a regression - it's a hardcoded absolute-time bound that doesn't hold up under runner load.CI_TIMEOUTheadroom this same test directory (tests/unit/file_cache/mp_test_utils.py) already uses for the same class of fork/scheduling-bootstrap variance.Test plan
uv run pytest tests/unit/file_cache/test_partial_cache_computation.py -vv(all 3 tests pass)uv run pytest tests/unit/ -m "not slow"(1171 passed, 5 skipped)🤖 Generated with Claude Code