Repository navigation
refactor(typing): clear the basedpyright warnings in the typecheck scope - #981
Merged
Merged
Conversation
kls -> cls as the first parameter of five classmethods: the two pre_stats_sample overrides, the post_process_df that add_processing generates in buckaroo_widget.py and xorq_buckaroo.py, and DefaultMainStyling.style_column (not in the typecheck scope yet; #980 adds it). InnerDataFlow._df_to_obj took `idfself` so its body could reach the widget's `self`. The widget is bound to `widget` before the class statement and the method takes a plain `self`. get_story_config(include_summary_stats=True) raises NotImplementedError instead of dividing by zero. Nothing calls it with True. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.6.dev36147622075or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.6.dev36147622075MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.15.6.dev36147622075" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table📖 Docs preview🎨 Storybook preview |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typecheck job reports 6 warnings on main, and they show up as annotations on any PR that touches these files. This clears them.
kls→clsas the first parameter of five classmethods:PdSampling.pre_stats_sample,ServerSampling.pre_stats_sample, thepost_process_dfthatadd_processinggenerates inbuckaroo_widget.pyandxorq_buckaroo.py, andDefaultMainStyling.style_column.customizations/styling.pyisn't in the typecheck scope on main, but typing: give init_sd's display config keys a type, type-check the styling files #980 adds it. All five are called positionally, so callers aren't affected.InnerDataFlow._df_to_objtookidfselfso its body could reach the widget'sself. The widget is now bound towidgetbefore the class statement, and the method takes a plainself.get_story_config(include_summary_stats=True)raisesNotImplementedErrorinstead of dividing by zero. Nothing calls it withTrue.Test
pyrightconfig.typecheck.json: 0 errors, 0 warnings (main: 0 errors, 6 warnings)pytest tests/unit: 1274 passed, 6 skipped🤖 Generated with Claude Code