Skip to content

refactor(typing): clear the basedpyright warnings in the typecheck scope - #981

Merged
paddymul merged 1 commit into
mainfrom
refactor/typecheck-warnings
Sep 25, 2026
Merged

paddymul merged 1 commit into
mainfrom
refactor/typecheck-warnings

Conversation

@paddymul

Copy link
Copy Markdown
Collaborator

The typecheck job reports 6 warnings on main, and they show up as annotations on any PR that touches these files. This clears them.

  • kls → cls as the first parameter of five classmethods: PdSampling.pre_stats_sample, ServerSampling.pre_stats_sample, the post_process_df that add_processing generates in buckaroo_widget.py and xorq_buckaroo.py, and DefaultMainStyling.style_column. customizations/styling.py isn't in the typecheck scope on main, but typing: give init_sd's display config keys a type, type-check the styling files #980 adds it. All five are called positionally, so callers aren't affected.
  • InnerDataFlow._df_to_obj took idfself so its body could reach the widget's self. The widget is now bound to widget before the class statement, and the method takes a plain self.
  • get_story_config(include_summary_stats=True) raises NotImplementedError instead of dividing by zero. Nothing calls it with True.

Test

  • basedpyright 1.39.8 on pyrightconfig.typecheck.json: 0 errors, 0 warnings (main: 0 errors, 6 warnings)
  • pytest tests/unit: 1274 passed, 6 skipped
  • ruff and paddy_format clean

🤖 Generated with Claude Code

kls -> cls as the first parameter of five classmethods: the two
pre_stats_sample overrides, the post_process_df that add_processing
generates in buckaroo_widget.py and xorq_buckaroo.py, and
DefaultMainStyling.style_column (not in the typecheck scope yet; #980
adds it).

InnerDataFlow._df_to_obj took `idfself` so its body could reach the
widget's `self`. The widget is bound to `widget` before the class
statement and the method takes a plain `self`.

get_story_config(include_summary_stats=True) raises NotImplementedError
instead of dividing by zero. Nothing calls it with True.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📦 TestPyPI package published

pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.6.dev36147622075

or with uv:

uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.15.6.dev36147622075

MCP server for Claude Code

claude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.15.6.dev36147622075" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table

📖 Docs preview

🎨 Storybook preview

@paddymul
paddymul enabled auto-merge September 25, 2026 14:30
@paddymul
paddymul added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 6d9d1e4 Sep 25, 2026
28 checks passed

This branch was successfully deployed

1 active deployment
testpypi — 1eeac87b Deployed Sep 25, 2026 by paddymul via Publish to TestPyPI #1576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant