Repository navigation
fix(sync): preserve additional headers in generic calls - #193
Open
WilliamK112 wants to merge 1 commit into
Open
WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
This was referenced Oct 13, 2026
btoron
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OFSApi.call()mergedadditionalHeadersand then immediately replaced that result with the default headers. CustomAcceptheaders and caller overrides therefore never reached the server. Keep the merged headers when sending the request.Addresses the separate
additionalHeadersdefect reported in #160; the synchronous streaming request in that issue remains open.Validation: 452 tests pass, 8 skip; Ruff check and formatting pass. Five new tests failed before the fix and now verify the real HTTP request against a temporary loopback server: custom headers, Content-Type and Authorization overrides, preserved body/query parameters, unchanged caller dictionaries, and no header leakage into later calls. No OFS credentials or external endpoint are used.