Skip to content

fix(models): accept capacity categories without names - #191

Merged
btoron merged 1 commit into
btoron:masterfrom
WilliamK112:codex/optional-capacity-category-name-189
Oct 13, 2026
Merged

btoron merged 1 commit into
btoron:masterfrom
WilliamK112:codex/optional-capacity-category-name-189

Conversation

@WilliamK112

Copy link
Copy Markdown
Contributor

OFSC can return capacity categories without a name key. The required string currently rejects the whole list page or a successful PUT reply. Make CapacityCategory.name optional with a default of None so those records can be read and updated.

Regression coverage includes missing, null, and present names, public single-item and paginated reads, and deactivating a nameless category with name omitted from its write body.

Fixes #189.

Validation with Python 3.13:

  • All 453 mocked tests pass, with 8 skipped. Five new cases failed before the model change; the named-category control already passed.
  • Full Ruff check, Ruff format check, and diff whitespace checks pass.

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@btoron
btoron merged commit 556a8da into btoron:master Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CapacityCategory.name should be Optional: OFSC serves capacity categories with no name

2 participants