docs(lens): flag the exposure misdirection and the 10-30 degree solver database - #652
Merged
Merged
Conversation
…r database A wrong Lens setting stops solving outright, and the symptom reads as an exposure fault: on AUTO the PiFinder keeps hunting up and down the exposure range and never solves. The Exposure bullet sits above the lens bullet under "It won't plate solve", so a reader works the wrong one first. Say so in the lens bullet. The bundled default_database.npz is built over [10.0, 30.0] degrees (props_packed: min_fov=10.0, max_fov=30.0), which is the real constraint on substituting a lens, so record it in the BOM note for the 16mm lens. Closes the two remaining gaps in #613. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #613.
What is left of #613
Most of #613 already landed.
BOM.rstgot the sensor-aware rewrite of the lensadvice,
troubleshooting.rstgained the "Did you fit a different lens?"bullet under "It won't plate solve", and
menu_map.rstdocuments the Lenssetting. This PR adds only the two gaps that remained.
1. The failure looks like an exposure problem. Under "It won't plate solve"
the Exposure bullet comes before the lens bullet, so a reader with a wrong
Lens setting works the exposure bullet first and finds nothing. The lens bullet
now names the misdirection:
I left the bullet order alone. The lens bullet is last because the two trailing
.. note::blocks belong to it, and moving it above Exposure would orphanthem or split the list. The warning inside the bullet addresses the diagnosis
problem directly, and leaving the order untouched keeps this diff clear of the
concurrent edit to the GPS section of the same file.
2. The tetra3 database range. The BOM note for the 16mm lens already
explained that field of view depends on the camera as well as the lens. It now
records the actual constraint on substituting one:
Where the 10-30 degree range was verified
Read directly out of the shipped database rather than taken from the ADR:
That is the file
PiFinder/solver.py:873loads(
tetra3.Tetra3(utils.tetra3_dir / "data" / "default_database.npz")), and thoseare the same
min_fov/max_fovkeys thatsolver.py::_warn_if_outside_solver_databasereads back atsolver.py:171to log a gate that lies outside the database. ADR 0029's[10.0, 30.0]claim checks out.One issue bullet is superseded
#613 says "No restart needed: the solver re-reads the lens per frame and
solving resumes on the next one." That is no longer true, and I have not
documented it.
PiFinder/ui/callbacks.py::set_camera_lensnow restartsdeliberately: tetra3's
_pattern_cacheis keyed on the pattern hash alone, andthe entries it holds were already pruned against whichever FOV gate was in force
when they were computed, so a lens change leaves stale entries in place and looks
like it did not take until the solver restarts. See that docstring and ADR 0029.
The docs already say "The PiFinder restarts when you change it" in both
troubleshooting.rstandmenu_map.rst, which is correct, so both are left asthey are.
Verification
python -m sphinx -b html -n -q source /tmp/sphinx_613prints nothing and exits0. The
BOM.rstlist-tablecell renders as a single<td>, checked in thebuilt HTML. No em-dashes or semicolons in the added lines.
🤖 Generated with Claude Code