feat(trace): add advanced span filters - #2466
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Open
feat(trace): add advanced span filters#2466Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Abhijeet Prasad (AbhiPrasad) wants to merge 2 commits into
Conversation
Add `filters` to `Trace.getSpans()` so callers can select spans by type,
name, error state, partial metadata, and duration without fetching the
whole trace and filtering it themselves.
```typescript
const spans = await trace.getSpans({
filters: {
spanType: ["tool"],
name: ["search", "lookup"],
hasError: true,
metadata: { model: "gpt-5" },
duration: { min: 0.5, max: 10 },
},
});
```
Combine filter dimensions with AND and match any value within each name
or span-type list. Duration bounds are inclusive and measured in seconds.
Keep the existing top-level `spanType` option supported.
Apply consistent filtering to buffered spans, complete trace caches, and
BTQL queries. Validate metadata as cycle-free JSON data, check returned
metadata candidates locally to avoid backend type coercion, and avoid
caching partial filtered results as complete traces.
Abhijeet Prasad (AbhiPrasad)
requested a review
from Luca Forstner (lforst)
September 10, 2026 18:33
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/braintrustdata/issue/SDK-343/add-filters-on-traceget-spans-to-javascript-sdk
Add
filterstoTrace.getSpans()so callers can select spans by type, name, error state, partial metadata, and duration without fetching the whole trace and filtering it themselves.Combine filter dimensions with AND and match any value within each name or span-type list. Duration bounds are inclusive and measured in seconds. Keep the existing top-level
spanTypeoption supported.Apply consistent filtering to buffered spans, complete trace caches, and BTQL queries. Validate metadata as cycle-free JSON data, check returned metadata candidates locally to avoid backend type coercion, and avoid caching partial filtered results as complete traces.