fix(python): preserve explicit token limits for Responses API - #222
Open
Kingsley_Li (kingsleyli920) wants to merge 2 commits into
Open
Kingsley_Li (kingsleyli920) wants to merge 2 commits into
Kingsley_Li (kingsleyli920) wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 756fceee36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMClassifier(max_tokens=256)silently loses its explicit output limit when routed to the Responses API, either automatically for GPT-5 or withuse_responses_api=True.prepare_responses_paramscurrently discards that field. This maps it to the Responses API'smax_output_tokens, so the caller's limit reaches the provider. Unspecified limits remain omitted.The fix is shared by the synchronous and asynchronous clients. The LiteLLM adapter also translates
max_output_tokensback tomax_tokensbefore dispatching tolitellm.completionorlitellm.acompletion, removing the Responses-only field. Both native OpenAI and LiteLLM paths therefore preserve the explicit limit.HTTP-boundary regression tests cover native clients, both routing modes, and explicitly supplied versus omitted limits. LiteLLM regressions exercise
LLMClassifierthrough the real Autoevals wrapper and adapter, inspecting the arguments at the completion boundary for synchronous/asynchronous, automatic/explicit Responses, and regular Chat Completions routes. Existing parameter tests now also assert the translated field instead of only checking thatmax_tokensis absent.Validation:
max_output_tokens; the 5 default-limit checks passed.test_llm.py,test_oai.py, andtest_litellm.pypassed with network sockets disabled. Four existing live model tests were excluded by exact test name.gpt-5.4-minisucceeded through the regular Autoevals client: outgoing Responses request containedmax_output_tokens: 768, HTTP 200, parsed score 1.0.This honors an explicitly requested limit and does not introduce a default token cap.