Repository navigation
fix: pin plugin dependencies broken by upstream releases - #427
Merged
Merged
Conversation
pyarrow 26.0.0 (2026-10-09) requires NumPy 2 at import time, but core and language pin numpy<2, so loading wikitext-2 fails with an ImportError.
NLTK 3.10 refuses to read corpora outside nltk.data.path, so BracketParseCorpusReader raises PermissionError on the bundled treebank.
An unconstrained tensorflow install upgrades numpy to 2.x, which breaks the plugin's xarray import (np.unicode_ was removed in NumPy 2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three plugins break against newly released third-party packages. All three failures showed up in the CI for #420. That PR edits
model_helpers, which makes CI test every language plugin, and none of the failures involve its diff.Failures and fixes
datasets==2.*, which does not cappyarrow.ImportError: pyarrow requires NumPy 2.0 or neweragainst ournumpy<2pin.tests/test_model_helpers/test_huggingface.py::TestNextWord::test_0_dimensional_tensor(Non-Plugins) on any PR that runs it.pyarrow<26.nltk.data.path.PermissionError: Security Violation [CorpusReader.__init__]: Unauthorized path .../earley_parser/treebank.nltk.data.pathbefore reading it.tensorflowinstall upgrades NumPy to 2.x.AttributeError: np.unicode_ was removed in the NumPy 2.0 release.numpy<2.Verification
pyarrow==26.0.0withnumpy==1.26.4reproduces the ImportError.pyarrow==25.0.1with the same NumPy imports cleanly.nltk==3.10.3reproduces the PermissionError on the bundled treebank. With the path added, all 11 trees insample_treebankparse.pip install --dry-runfor linux x86_64 / Python 3.11:tensorflowalone resolves to numpy 2.4.6, which reproduces the lm1b failure.tensorflowwithnumpy<2resolves to tensorflow 2.20.0 and numpy 1.26.4.datasets==2.*withpyarrow<26andnumpy<2resolves to datasets 2.21.0, pyarrow 25.0.1 and numpy 1.26.4.