Skip to content

Update composefs-rs to v0.9.0 tag - #2393

Merged
Johan-Liebert1 merged 1 commit into
bootc-dev:mainfrom
cgwalters:bump-composefs
Aug 26, 2026
Merged

Update composefs-rs to v0.9.0 tag#2393
Johan-Liebert1 merged 1 commit into
bootc-dev:mainfrom
cgwalters:bump-composefs

Conversation

@cgwalters

Copy link
Copy Markdown
Collaborator

Switch from pinning a specific commit rev to pinning the v0.9.0 git tag, which is easier to track against upstream releases.

This version splits UKI addons into two kinds: PEType::UkiAddon, scoped to a single UKI (found alongside it under a <uki>.efi.extra.d directory), and the new PEType::GlobalUkiAddon, which applies to every UKI per systemd-stub's addon spec (found under /boot/loader/addons).

Extract the ESP output directory computation for a PE binary into its own pe_output_dir() helper so it's independently testable, and teach it to route global addons to the shared "loader/addons" directory on the ESP instead of namespacing them under a deployment's UKI directory like per-UKI addons. Global addons are still gated behind --uki-addon like their per-UKI counterparts, since installing arbitrary addons found in the image without explicit opt-in would be surprising.

Assisted-by: https://github.com/cgwalters/cgwalters#llms

@bootc-bot
bootc-bot Bot requested a review from ckyrouac August 19, 2026 17:56
@cgwalters cgwalters added the ci/merge Run full CI suite (all OSes) — equivalent to merge queue label Aug 19, 2026
jeckersb
jeckersb previously approved these changes Aug 19, 2026
@jeckersb
jeckersb enabled auto-merge (rebase) August 19, 2026 19:30
@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

Closing and repoening to retrigger CI

auto-merge was automatically disabled August 25, 2026 09:40

Pull request was closed

Johan-Liebert1
Johan-Liebert1 previously approved these changes Aug 25, 2026
@Johan-Liebert1
Johan-Liebert1 enabled auto-merge (rebase) August 25, 2026 09:41
@jeckersb

Copy link
Copy Markdown
Collaborator

Needs rebased, main removed the PathBuf import so this is a sneaky merge non-conflict failing CI.

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

/copilot rebase this PR on top of main

@Johan-Liebert1

Copy link
Copy Markdown
Collaborator

Welp, that didn't work. I could swear we had a rebase command. Rebased and pushed

Switch from pinning a specific commit rev to pinning the v0.9.0 git
tag, which is easier to track against upstream releases.

Update to handle the two UKI addon kinds.

Assisted-by: https://github.com/cgwalters/cgwalters#llms
Signed-off-by: Colin Walters <walters@verbum.org>

Import `PathBuf`

Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
@Johan-Liebert1
Johan-Liebert1 dismissed stale reviews from jeckersb and themself via 0d539de August 26, 2026 03:19
@Johan-Liebert1
Johan-Liebert1 merged commit 20d9b36 into bootc-dev:main Aug 26, 2026
114 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/merge Run full CI suite (all OSes) — equivalent to merge queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants