Repository navigation
Expose DescWindowVisibility and toggle key on LanguageSupport - #122
Merged
Merged
Conversation
Replace get/setShowDescWindow(boolean) with get/setDescWindowVisibility(DescWindowVisibility), which adds access to ON_DEMAND, and add get/setDescWindowToggleKey(KeyStroke). AbstractLanguageSupport applies both to every installed AutoCompletion. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
bobbylight
force-pushed
the
desc-window-visibility
branch
from
October 17, 2026 22:08
14d418d to
c7247b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanguageSupport#get/setShowDescWindow(boolean)in favor ofget/setDescWindowVisibility(DescWindowVisibility), giving consumers access toALWAYS,ON_DEMANDandNEVER(previouslyON_DEMANDwas unreachable after the AutoComplete 4.0 port)get/setDescWindowToggleKey(KeyStroke); both settings are per-LanguageSupportand pushed to all installedAutoCompletions, like the other optionsAbstractLanguageSupport#configureDescWindow(AutoCompletion)replaces the duplicated boolean-to-enum ternaries in the abstract class, Java and JavaScript supportNEVERunless a language's constructor opts in withALWAYS; toggle key defaults to AutoComplete's (Ctrl+Shift+Space)AbstractLanguageSupportTestTest plan
./gradlew build(includes checkstyle and tests)🤖 Generated with Claude Code