Repository navigation
Pluralise the counts in the list summary - #91
Merged
Merged
Conversation
`samplerdisc list` printed "5 sample" and "1 volumes" -- the count nouns were never pluralised. The kind word stays the backend's own (AKAI says sample and program, ADR-0023); only the plural -s was missing. A small _plural helper now handles the volume, file, partition and kind counts, so "1 volume, 1 sample" and "2 volumes, 3 samples" both read correctly. Adds the first test of the list summary output, singular and plural. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
samplerdisc listprinted count nouns without a plural: "5 sample", and "1 volumes" / "1 file" for the singular cases. This adds a small_plural(count, noun)helper and applies it to the volume, file, partition, and kind counts.The kind word stays the backend's own vocabulary — AKAI says sample and program (ADR-0023) — the fix only adds the missing
-s. Every noun involved (volume, file, partition, sample, program, wav, aiff) pluralises with a plain-s, so nothing cleverer is needed.Before / after:
Test
Adds the first coverage of the
listsummary line — both the plural case (2 volumes / 3 samples / a 2-file and a 1-file volume) and the singular case (1 volume / 1 sample).listhad no output test before.Why now
Spotted while building the README demo GIF (#90), where the glitch was about to be immortalised. This lands first so the GIF can be regenerated on top of it.
🤖 Generated with Claude Code