test: assert what the fixture commands carry - #33
Merged
Merged
Conversation
The petstore, openai and billing tests sent a command through a mock server and then checked that the result was truthy, which nothing could fail. They now assert the method, path, query and serialized body the generated command carries, which is what codegen decides. The event stream test still runs through the client, since it checks the parsed events and their type. Co-Authored-By: LLM <noreply@maxholman.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The petstore, openai and billing tests sent a command through a mock server and then asserted
toBeTruthy(), which nothing could fail. They now assert the method, path, query and serialized body on the generated command itself, since those are what codegen decides.The event stream test still goes through the client, because it checks the parsed events and their type.