refactor: name functions by what they do - #31
Merged
Merged
Conversation
maxholman
Bot
force-pushed
the
perf/batch-statements
branch
from
September 27, 2026 12:28
7c21f7d to
c746e50
Compare
A preposition suffix (`jsonBodyTypeOf`, `separatorIn`, `warningsFrom`) names a relation rather than the work, so each becomes a verb phrase: resolveJsonBodyType, buildTypesModuleSpecifier, resolveTypeName, extractSchemaName, openChunk, readStatementSeparator, and in the tests buildIntoTempDir, collectWarnings, readRequestedUrl. The chunk map becomes chunksByFile. Co-Authored-By: LLM <noreply@block65.dev>
maxholman
Bot
force-pushed
the
refactor/verb-names
branch
from
September 27, 2026 12:32
f013b3c to
ba58d5c
Compare
The command holds its query and names its serializer, so the tests read them directly instead of sending it through a client to a stubbed fetch. sortQuery is rest-client's to test, so its test here is gone. Co-Authored-By: LLM <noreply@maxholman.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames functions whose name ends in a preposition (Of, In, From) to a verb phrase that says what they do:
jsonBodyTypeOfresolveJsonBodyTypetypesModuleSpecifierOfbuildTypesModuleSpecifiertypeNameOfresolveTypeNameschemaNameOfextractSchemaNamechunkOfopenChunkseparatorInreadStatementSeparatorchunksOf(map)chunksByFilebuildIn(test)buildIntoTempDirwarningsFrom(test)collectWarningsurlFrom(test)readRequestedUrlThe change is only renames, and the generated output is identical. Stacked on #30.