block65 · maxholman · Sep 27, 2026 · Sep 27, 2026 · Sep 27, 2026 · Sep 27, 2026
diff --git a/..._/codegen-regressions/a-ref-nested-past-the-top-level-registers-after-its-target/types.ts b/..._/codegen-regressions/a-ref-nested-past-the-top-level-registers-after-its-target/types.ts
diff --git a/...codegen-regressions/a-ref-nested-past-the-top-level-registers-after-its-target/valibot.ts b/...codegen-regressions/a-ref-nested-past-the-top-level-registers-after-its-target/valibot.ts
diff --git a/...__/codegen-regressions/a-single-member-combinator-emits-the-member-alone-anyof/valibot.ts b/...__/codegen-regressions/a-single-member-combinator-emits-the-member-alone-anyof/valibot.ts
diff --git a/...__/codegen-regressions/a-single-member-combinator-emits-the-member-alone-oneof/valibot.ts b/...__/codegen-regressions/a-single-member-combinator-emits-the-member-alone-oneof/valibot.ts
diff --git a/...regressions/a-single-member-combinator-emits-the-member-alone-two-member-oneof/valibot.ts b/...regressions/a-single-member-combinator-emits-the-member-alone-two-member-oneof/valibot.ts
diff --git a/.../codegen-regressions/a-value-the-schema-leaves-open-is-a-jsonvalue-on-both-sides/types.ts b/.../codegen-regressions/a-value-the-schema-leaves-open-is-a-jsonvalue-on-both-sides/types.ts
diff --git a/...odegen-regressions/a-value-the-schema-leaves-open-is-a-jsonvalue-on-both-sides/valibot.ts b/...odegen-regressions/a-value-the-schema-leaves-open-is-a-jsonvalue-on-both-sides/valibot.ts
diff --git a/...gressions/additionalproperties-alongside-properties-keeps-the-extra-keys-valid/valibot.ts b/...gressions/additionalproperties-alongside-properties-keeps-the-extra-keys-valid/valibot.ts
diff --git a/...odegen-regressions/additionalproperties-chooses-the-object-schema-empty-schema/valibot.ts b/...odegen-regressions/additionalproperties-chooses-the-object-schema-empty-schema/valibot.ts
diff --git a/...ots__/codegen-regressions/additionalproperties-chooses-the-object-schema-false/valibot.ts b/...ots__/codegen-regressions/additionalproperties-chooses-the-object-schema-false/valibot.ts
diff --git a/...degen-regressions/additionalproperties-chooses-the-object-schema-string-schema/valibot.ts b/...degen-regressions/additionalproperties-chooses-the-object-schema-string-schema/valibot.ts
diff --git a/...hots__/codegen-regressions/additionalproperties-chooses-the-object-schema-true/valibot.ts b/...hots__/codegen-regressions/additionalproperties-chooses-the-object-schema-true/valibot.ts
diff --git a/...e-instead-of-widening-to-unknown/types.ts → ...g-keyed-record-of-the-value-type/types.ts b/...e-instead-of-widening-to-unknown/types.ts → ...g-keyed-record-of-the-value-type/types.ts
diff --git a/...instead-of-widening-to-unknown/valibot.ts → ...keyed-record-of-the-value-type/valibot.ts b/...instead-of-widening-to-unknown/valibot.ts → ...keyed-record-of-the-value-type/valibot.ts
diff --git a/...__/__snapshots__/codegen-regressions/additionalproperties-true-accepts-any-key/valibot.ts b/...__/__snapshots__/codegen-regressions/additionalproperties-true-accepts-any-key/valibot.ts
diff --git a/...codegen-regressions/an-empty-properties-bag-is-a-record-not-an-empty-object-type/types.ts b/...codegen-regressions/an-empty-properties-bag-is-a-record-not-an-empty-object-type/types.ts
diff --git a/...ts__/codegen-regressions/an-object-schema-that-omits-type-still-honours-required/types.ts b/...ts__/codegen-regressions/an-object-schema-that-omits-type-still-honours-required/types.ts
diff --git a/.../nullables/3-0-nullable-objects-arrays-strings-and-combinator-members-admit-null/types.ts b/.../nullables/3-0-nullable-objects-arrays-strings-and-combinator-members-admit-null/types.ts
diff --git a/...ullables/3-0-nullable-objects-arrays-strings-and-combinator-members-admit-null/valibot.ts b/...ullables/3-0-nullable-objects-arrays-strings-and-combinator-members-admit-null/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/const-values/valibot.ts b/__tests__/__snapshots__/nullables/const-values/valibot.ts
diff --git a/...s__/__snapshots__/nullables/enums-short-circuit-type-constraints-picklist-only/valibot.ts b/...s__/__snapshots__/nullables/enums-short-circuit-type-constraints-picklist-only/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/header-parameters/valibot.ts b/__tests__/__snapshots__/nullables/header-parameters/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/input-only-mode-omits-wire-schemas/valibot.ts b/__tests__/__snapshots__/nullables/input-only-mode-omits-wire-schemas/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/oneof-with-type-null-generates-v-null/valibot.ts b/__tests__/__snapshots__/nullables/oneof-with-type-null-generates-v-null/valibot.ts
diff --git a/...napshots__/nullables/query-and-header-integer-params-coerce-strings-to-numbers/valibot.ts b/...napshots__/nullables/query-and-header-integer-params-coerce-strings-to-numbers/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/rfc-3339-temporal-formats/valibot.ts b/__tests__/__snapshots__/nullables/rfc-3339-temporal-formats/valibot.ts
diff --git a/__tests__/__snapshots__/nullables/top-level-type-array-with-null/valibot.ts b/__tests__/__snapshots__/nullables/top-level-type-array-with-null/valibot.ts
diff --git a/__tests__/codegen-regressions.test.ts b/__tests__/codegen-regressions.test.ts
@@ -190,7 +190,7 @@ function docWithSchema(name: string, schema: oas31.SchemaObject) {
 	};
 }
 
-test("additionalProperties types the record value instead of widening to unknown", async () => {
+test("additionalProperties is a string-keyed record of the value type", async () => {
 	const result = await processOpenApiDocument(
 		"/tmp/whatever",
 		docWithSchema("Labels", {
@@ -470,3 +470,81 @@ test("a oneOf query param keeps the stringish wire types in every branch", async
 
 	await expectGenerated([result.typesFile]);
 });
+
+test("an object schema that omits `type` still honours `required`", async () => {
+	const result = await processOpenApiDocument("/tmp/whatever", {
+		openapi: "3.1.0",
+		info: { title: "Test", version: "1.0.0" },
+		paths: {},
+		components: {
+			schemas: {
+				Untyped: {
+					required: ["id"],
+					properties: { id: { type: "string" }, note: { type: "string" } },
+				},
+			},
+		},
+	});
+
+	await expectGenerated([result.typesFile]);
+});
+
+test("a $ref nested past the top level registers after its target", async () => {
+	const result = await processOpenApiDocument("/tmp/whatever", {
+		openapi: "3.1.0",
+		info: { title: "Test", version: "1.0.0" },
+		paths: {},
+		components: {
+			schemas: {
+				// each refers to Leaf before it is declared
+				InArrayItem: {
+					type: "array",
+					items: {
+						type: "object",
+						properties: { leaf: { $ref: "#/components/schemas/Leaf" } },
+					},
+				},
+				InRecord: {
+					type: "object",
+					additionalProperties: { $ref: "#/components/schemas/Leaf" },
+				},
+				InUnionBesideProperties: {
+					type: "object",
+					properties: { id: { type: "string" } },
+					allOf: [{ $ref: "#/components/schemas/Leaf" }],
+				},
+				Leaf: {
+					type: "object",
+					properties: { name: { type: "string" } },
+					additionalProperties: false,
+				},
+			},
+		},
+	});
+
+	await expectGenerated([result.typesFile, result.valibotFile]);
+});
+
+test("a value the schema leaves open is a JsonValue on both sides", async () => {
+	const result = await processOpenApiDocument("/tmp/whatever", {
+		openapi: "3.1.0",
+		info: { title: "Test", version: "1.0.0" },
+		paths: {},
+		components: {
+			schemas: {
+				Open: {
+					type: "object",
+					required: ["anything", "record", "list"],
+					properties: {
+						anything: {},
+						record: { type: "object", additionalProperties: true },
+						list: { type: "array" },
+					},
+					additionalProperties: false,
+				},
+			},
+		},
+	});
+
+	await expectGenerated([result.typesFile, result.valibotFile]);
+});
diff --git a/__tests__/fixtures/docker/.openapi-codegen-manifest.json b/__tests__/fixtures/docker/.openapi-codegen-manifest.json