Repository navigation
Fix change-check semantics and baseline recording - #1
Merged
Merged
Conversation
Correct several pre-existing bugs in the change-check evaluation path: - on_change: proceed had inverted polarity. Unchanged targets now return Passed (step's work is done) and changed targets return Failed (step must re-run). Previously these were reversed. - Missing, unreadable, and oversized change targets returned Failed. They now return Indeterminate (no verdict), so the evaluator falls through to the next satisfaction signal rather than blocking the step on unhashable targets. - Baselines were never recorded during bivvy run. CheckEvaluator now exposes record_run_baselines, called from both execution paths after each successful step. Dry-run executions are guarded and do not write baselines. - evaluate_any collapsed an all-Indeterminate result set to Failed. It now returns Indeterminate when no branch passed and at least one was Indeterminate. - A failing check could fall through to the rerun window, allowing a step to be skipped even when its check explicitly reported work left to do. The satisfaction hierarchy now short-circuits on Failed. Also updates documentation, bundled templates, and the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_change: proceedpolarity: unchanged targets nowreturn Passed (step satisfied), changed targets return Failed (step must
re-run). Previously these were reversed.
instead of Failed, so the evaluator falls through to the next satisfaction
signal rather than blocking the step.
detection works without capturing a snapshot manually first. Dry-run
executions do not record baselines.
evaluate_anynow returns Indeterminate when all branches are Indeterminate,rather than collapsing to Failed.
checkno longer falls through to the rerun window - a step whosecheck explicitly reports work left to do is not considered satisfied.