Repository navigation
Make sure the ROQ waveform generator wrapper is picklable - #1149
Open
ColmTalbot wants to merge 2 commits into
Open
ColmTalbot wants to merge 2 commits into
ColmTalbot wants to merge 2 commits into
Conversation
mj-will
requested changes
Sep 18, 2026
mj-will
left a comment
mj-will
left a comment
Collaborator
There was a problem hiding this comment.
I think we should add a small test for this.
Collaborator
Author
I added a test that I verified raised a RuntimeError without this change. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@asb5468 pointed out that the ROQ likelihood is failing in py3.14.
This fixes a pickle issue when using forkserver with multiprocessing.
I'm not sure what a useful test looks like here.