Change stamp.sh into stamp.py - #389
AndreiDurlea wants to merge 2 commits into
Conversation
230fe6e to
f1cad19
Compare
1d6228d to
73e9789
Compare
|
Updated this with main just now, everything is passing. Could be useful for users on other platforms as well. Is this a wanted change? @neatudarius @ednolan |
wusatosi
left a comment
There was a problem hiding this comment.
The bash script -> python transcription is sound.
The motivation is right.
@ednolan , @camio , @neatudarius care to chime in?
|
In general, we should reduce the use of bash scripts. So it is the right way to the future. But note this file may be obsolete if we switch from |
ednolan
left a comment
There was a problem hiding this comment.
I want to hold this commit back until we can reconcile it with the copier changes. Having both of them in flux at the same time is going to result in the need for rebasing one on the other which I want to wrap my head around before we merge it.
Alright, I'll wait for the copier stuff to hit main before coming back to this PR. PS: when i first made this PR, i had an asus, so I cared more about this kinda issue =). Now that I own a macbook (finally!), such issues might no longer catch my eye - we need to get windows users on the team=) |
Congrats on your new laptop! We can test this using the windows runners. |
Fixes #388 (implements option 1) and allows windows users to run the stamp script easily. Also allows doing certain CI jobs that test on cookiecutter's output (bemanproject/beman-tidy#312) on windows-latest