Skip to content

Change stamp.sh into stamp.py - #389

Open
AndreiDurlea wants to merge 2 commits into
bemanproject:mainfrom
AndreiDurlea:388-windows-users-cannot-run-stampsh-without-wsl
Open

AndreiDurlea wants to merge 2 commits into
bemanproject:mainfrom
AndreiDurlea:388-windows-users-cannot-run-stampsh-without-wsl

Conversation

@AndreiDurlea

Copy link
Copy Markdown
Member

Fixes #388 (implements option 1) and allows windows users to run the stamp script easily. Also allows doing certain CI jobs that test on cookiecutter's output (bemanproject/beman-tidy#312) on windows-latest

Comment thread stamp.py Outdated
@coveralls

coveralls commented May 4, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same — AndreiDurlea:388-windows-users-cannot-run-stampsh-without-wsl into bemanproject:main

@AndreiDurlea
AndreiDurlea force-pushed the 388-windows-users-cannot-run-stampsh-without-wsl branch 2 times, most recently from 230fe6e to f1cad19 Compare May 4, 2026 23:11
@AndreiDurlea
AndreiDurlea marked this pull request as ready for review May 4, 2026 23:16
@AndreiDurlea
AndreiDurlea force-pushed the 388-windows-users-cannot-run-stampsh-without-wsl branch from 1d6228d to 73e9789 Compare June 2, 2026 13:42
@AndreiDurlea

Copy link
Copy Markdown
Member Author

Updated this with main just now, everything is passing. Could be useful for users on other platforms as well. Is this a wanted change? @neatudarius @ednolan

@AndreiDurlea
AndreiDurlea requested a review from RaduNichita June 19, 2026 12:48

@wusatosi wusatosi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bash script -> python transcription is sound.
The motivation is right.

@ednolan , @camio , @neatudarius care to chime in?

@ClausKlein

Copy link
Copy Markdown
Contributor

In general, we should reduce the use of bash scripts. So it is the right way to the future.

But note this file may be obsolete if we switch from cookiecutter to copier!

@ednolan ednolan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to hold this commit back until we can reconcile it with the copier changes. Having both of them in flux at the same time is going to result in the need for rebasing one on the other which I want to wrap my head around before we merge it.

@AndreiDurlea

Copy link
Copy Markdown
Member Author

I want to hold this commit back until we can reconcile it with the copier changes. Having both of them in flux at the same time is going to result in the need for rebasing one on the other which I want to wrap my head around before we merge it.

Alright, I'll wait for the copier stuff to hit main before coming back to this PR.

PS: when i first made this PR, i had an asus, so I cared more about this kinda issue =). Now that I own a macbook (finally!), such issues might no longer catch my eye - we need to get windows users on the team=)

@wusatosi

wusatosi commented Aug 6, 2026

Copy link
Copy Markdown
Member

PS: when i first made this PR, i had an asus, so I cared more about this kinda issue =). Now that I own a macbook (finally!), such issues might no longer catch my eye - we need to get windows users on the team=)

Congrats on your new laptop! We can test this using the windows runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows users cannot run stamp.sh without WSL

6 participants