Skip to content

chore: fix the contributor docs, templates and CI - #43

Merged
AlexeyShalaev merged 1 commit into
masterfrom
chore/review-fixes
Oct 7, 2026
Merged

AlexeyShalaev merged 1 commit into
masterfrom
chore/review-fixes

Conversation

@AlexeyShalaev

Copy link
Copy Markdown
Member

Found while filling in the project profile:

  • the pull request template asked for a CHANGELOG.md entry under [Unreleased], but release-please generates the changelog: the item now asks for a Conventional Commit title, as in clientwright;
  • the issue template config linked to GitHub Discussions, which are disabled: the link is gone;
  • CI tested Python 3.12 and 3.13; it now tests 3.14 too, and the classifiers list it (unit and integration tests pass on 3.14 locally);
  • make install and CONTRIBUTING.md install --all-extras, as CI does: without them mypy cannot load its pydantic plugin and 13 test modules fail at collection;
  • CONTRIBUTING.md said the integration tests need Docker; they start an in-process gRPC server;
  • the CI integration job accepted pytest's exit code 5 (no tests collected), a leftover from before there were integration tests;
  • .agents/project.md follows these changes.

- PR template: replace the "CHANGELOG.md updated under [Unreleased]"
  item with a Conventional Commit title item; release-please writes
  the changelog.
- Issue template config: drop the Discussions contact link, as
  Discussions are disabled, and the empty contact_links key.
- CI: test on Python 3.14 too (3.12 to 3.14) and add the 3.14
  classifier.
- make install and CONTRIBUTING.md: sync with --all-extras, as CI
  does; mypy needs pydantic for its plugin.
- CONTRIBUTING.md: the integration tests run an in-process server
  and need no Docker.
- CI: the integration job no longer accepts pytest's exit code 5
  (no tests collected).
- Project profile: drop the notes about the fixed mismatches.
@AlexeyShalaev
AlexeyShalaev merged commit 90fce7b into master Oct 7, 2026
6 checks passed
@AlexeyShalaev
AlexeyShalaev deleted the chore/review-fixes branch October 7, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant