Repository navigation
feat(agents): review in slices, check pure refactors, concrete guidelines - #13
Merged
Merged
Conversation
touchmark planHub
Scope: every target (13): hub.yml changed opt_in: assumed: 11 targets without an opt-in file are opted in by targets.yml; an opt-in file with enabled: false opts one out
open (13)
This hub pull request changes, across the targets it affects (10)
Cost: gh ≈ 39 writes (~1 min) · 1 run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes engineering-assets-template#9 into
agents,claudeandpython-library, byte for byte (python-serviceis not delivered here)..agents/prompts/review.mdreviews a large change in slices, then as a whole, checks every finding at its line, and asks every addition for its reason ("Justify or remove")..agents/prompts/pure-refactor.md(new) checks that a change keeps behaviour;/review-change pure-refactorruns it.AGENTS.mdgains working principles;/review-changefans slices out toreviewersubagents;/prchecks the docs before the description.python-libraryguidelines (python.md,testing.md) gain concrete rules.expected.md, with the libraries' default branches of 2026-10-11: every library isopenedwith 1 file created (.agents/prompts/pure-refactor.md) and 9 updated.scripts/check_plan.py --statuson fresh clones of all 13 matches it; the profiles staylocal, and mattermind's and pg-partsmith's ignored files stay ignored.On merge, distribute opens one sync pull request in each of the 13 libraries. Once they are merged, expected.md goes back to "nothing changes".
scripts/validate.sh --release --publicpasses.