Skip to content

fix: generate publish wheels for target platforms - #4007

Open
tomatotomata wants to merge 3 commits into
bazel-contrib:mainfrom
tomatotomata:codex/publish-target-platforms
Open

fix: generate publish wheels for target platforms#4007
tomatotomata wants to merge 3 commits into
bazel-contrib:mainfrom
tomatotomata:codex/publish-target-platforms

Conversation

@tomatotomata

@tomatotomata tomatotomata commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • add the Linux x86_64, Linux aarch64, macOS aarch64, and Windows x86_64 targets used by the publish dependency hub
  • keep the existing per-platform requirements files unchanged

Issue #3911 reports that requirements_by_platform only materializes wheels for the platform that evaluates the module extension. I was thinking the smallest fix is to declare the four platforms already represented by the publish requirement files. The Windows target was added after Buildkite's Windows Bazel 8 and 9 jobs exposed that omission.

Validation

  • git diff --check passed
  • Buildifier formatting passed
  • Bazel is not installed in this environment, so I could not run the repository analysis matrix
  • Buildkite's Linux and macOS configurations passed on the first follow-up run; the Windows configs are covered by the windows_x86_64 follow-up commit and are awaiting their new run

The issue maintainer said they are happy to accept a PR for this change. Let me know what you think.

Comment thread MODULE.bazel
"//tools/publish:requirements_windows.txt": "windows_*",
},
target_platforms = [
"linux_x86_64",

@aignas aignas Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the correct thing to do here would be this:

Suggested change
"linux_x86_64",
"{os}_{arch}",
# Below platforms are added to support cases where we are using
# RBE to build and push the wheels
"linux_x86_64",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants