fix: generate publish wheels for target platforms - #4007
Open
tomatotomata wants to merge 3 commits into
Open
Conversation
aignas
reviewed
Aug 5, 2026
| "//tools/publish:requirements_windows.txt": "windows_*", | ||
| }, | ||
| target_platforms = [ | ||
| "linux_x86_64", |
Collaborator
There was a problem hiding this comment.
I think the correct thing to do here would be this:
Suggested change
| "linux_x86_64", | |
| "{os}_{arch}", | |
| # Below platforms are added to support cases where we are using | |
| # RBE to build and push the wheels | |
| "linux_x86_64", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #3911 reports that
requirements_by_platformonly materializes wheels for the platform that evaluates the module extension. I was thinking the smallest fix is to declare the four platforms already represented by the publish requirement files. The Windows target was added after Buildkite's Windows Bazel 8 and 9 jobs exposed that omission.Validation
git diff --checkpassedwindows_x86_64follow-up commit and are awaiting their new runThe issue maintainer said they are happy to accept a PR for this change. Let me know what you think.