feat(eip8130): re-pin Keystore contract set to finalized deployment - #4322
Open
chunter-cb wants to merge 1 commit into
Open
feat(eip8130): re-pin Keystore contract set to finalized deployment#4322chunter-cb wants to merge 1 commit into
chunter-cb wants to merge 1 commit into
Conversation
1 task
chunter-cb
force-pushed
the
feat/eip8130-keystore-addresses
branch
from
August 10, 2026 16:57
e992323 to
17f704b
Compare
Comment on lines
+10
to
+11
| //! contract shares the `0x8130…` vanity prefix (except | ||
| //! [`Self::ALWAYS_VALID_AUTHENTICATOR`], a test/keyless helper deployed under the |
Contributor
There was a problem hiding this comment.
Self::ALWAYS_VALID_AUTHENTICATOR won't resolve in a module-level //! doc comment — there's no Self at module scope. This will produce a broken intra-doc link (rustdoc warns / errors depending on lint level). Should be Eip8130Contracts::ALWAYS_VALID_AUTHENTICATOR.
Suggested change
| //! contract shares the `0x8130…` vanity prefix (except | |
| //! [`Self::ALWAYS_VALID_AUTHENTICATOR`], a test/keyless helper deployed under the | |
| //! contract shares the `0x8130…` vanity prefix (except | |
| //! [`Eip8130Contracts::ALWAYS_VALID_AUTHENTICATOR`], a test/keyless helper deployed under the |
chunter-cb
force-pushed
the
feat/eip8130-keystore-addresses
branch
from
August 10, 2026 21:52
17f704b to
80fafb9
Compare
chunter-cb
changed the base branch from
feat/eip8130-admin-actor-delegation
to
main
August 10, 2026 21:52
Collaborator
🟡 Heimdall Review Status
|
The reference contracts (base/eip-8130) finalized under a mined, non-zero CREATE2 salt shared across the whole set (yielding the Keystore's 0x8130… vanity address). Re-pin every address, the shared salt, and the four changed init-code hashes; the high-rate-payer proxy code hash is updated to match the new implementation. P256/WebAuthn/AlwaysValid init-code hashes are unchanged — only their addresses moved with the salt. Verified against the base/eip-8130 Deploy.s.sol broadcast (chain 84532): each address CREATE2-derives from factory + shared salt + init-code hash (addresses_match_create2_derivation stays green).
chunter-cb
force-pushed
the
feat/eip8130-keystore-addresses
branch
from
August 10, 2026 23:20
80fafb9 to
71b5929
Compare
Contributor
Review SummarySingle-file constant-value update re-pinning the EIP-8130 contract set to the finalized deployment. No issues found. What changed:
Verified:
No correctness, safety, or API design concerns. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-pin the EIP-8130 system-contract set in
addresses.rsto the finalizedbase/eip-8130deployment (contract renamedAccountConfiguration→Keystore).0x8130…vanity address). UpdatesSALT(wasB256::ZERO), all seven addresses, and the four changed init-code hashes.P256/WebAuthn/AlwaysValidinit-code hashes are unchanged — only their addresses moved with the salt.Verified against the
base/eip-8130Deploy.s.solbroadcast (chain 84532): each address CREATE2-derives from factory + shared salt + init-code hash.Test plan
cargo test -p base-common-consensus --lib addresses::(incl.addresses_match_create2_derivation) passes