Skip to content

fix(fish): restore Linux tool PATH lost in #68; one 10-core.fish for every host - #74

Merged
barbatdev merged 1 commit into
mainfrom
fix/restore-linux-fish-path
Oct 21, 2026
Merged

barbatdev merged 1 commit into
mainfrom
fix/restore-linux-fish-path

Conversation

@barbatdev

Copy link
Copy Markdown
Owner

#68 branched before #60-#62; its 10-core.fish overwrote their Linux PATH block and the macOS-only o alias. Hosts kept older copies and each edited its own directory list, so every host ran a different file.

  • Restore the Linux block with the union of every host's dirs (/usr/local/go/bin, ~/.local/go-*/bin, bun, pnpm, nix, opencode, ~/.local/bin); each is added only if it exists. mise dropped (removed on all hosts).
  • Restore alias o open on macOS only.
  • New fish/tests/w8-linux-path.fish; CI now runs w7 and w8.

Differential (login PATH, host copy vs this file): nan identical; agent-dev, agent-gentle gain only ~/.gentle-ai/bin (#70); agent-refactoria gains ~/.opencode/bin (installed there). No host loses a dir.

Refs #69

…y host

#68 branched before #60-#62 and its 10-core.fish overwrote their Linux
PATH block and the macOS-only open alias. Hosts kept older copies and
each edited its own directory list. Restore both with the union of every
host's dirs (each added only if it exists) so all hosts share one file.
Run the w7/w8 fish tests in CI.

Refs #69
@barbatdev
barbatdev merged commit bac9814 into main Oct 21, 2026
1 check passed
@barbatdev
barbatdev deleted the fix/restore-linux-fish-path branch October 21, 2026 13:05
@barbatdev

Copy link
Copy Markdown
Owner Author

Post-merge QA (glm)

Restores the Linux tool PATH block lost in #68's overwrite, with the union of every host's dirs, each added only if it exists; the macOS-only o alias is now platform-guarded; new w8 test added to CI. Verified the one risky construct directly against fish 3.7.0: the unquoted $HOME/.local/go-*/bin glob does expand and test -d resolves the expanded dir, so the Go entry works despite the quoted siblings; the w8 expectations match the real expansion order. No defects found; one metadata note below.

Question (1)

Verdict: clean

@barbatdev

Copy link
Copy Markdown
Owner Author

Post-merge QA (deepseek)

Lens: evidence + test design.

The merge restores what #68 overwrote and makes it verifiable: the Linux block comes back as one union list with existence guards, the o alias is now macOS-only, and CI runs the new w8-linux-path.fish alongside w7. The w8 fixture is honest about its limits — a fake uname, a fake HOME, and assertions restricted to $home/* paths so runner-specific system dirs cannot make it flaky — and it checks three distinct things: the exact order under a populated HOME, the precedence of ~/.local/bin, the absence of the macOS alias on Linux, and that a bare HOME gains nothing. Both the ordering and the alias halves of the PR's claim therefore have real evidence.

No defects found. The one evidence gap is the two system entries in the Linux list (/usr/local/go/bin, and the nix prefixes), which no runner fixture can create, so a typo there would not be caught.

Suggestion (1)

  • /usr/local/go/bin and the system nix prefixes are never asserted (fish/tests/w8-linux-path.fish:27): The fixture asserts only entries under the fake HOME, and the test says so for /nix. /usr/local/go/bin is in the same category: on the CI runner the directory does not exist, so the guard skips it and no assertion would notice if the path were misspelled or dropped in a later edit. Since that entry is specifically part of what feat: RefactorIA CLI parity + graceful navigation fallback #68 lost, a cheap guard would be to assert the literal list the file contains (e.g. string match -q '*tool_bin in /usr/local/go/bin*' over the file text) or to note the limit next to the existing comment.

Verdict: clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant