Repository navigation
feat: translated metadata, hreflang and a sitemap for every language - #102
Merged
Merged
Conversation
- Title, description and Open Graph/Twitter text come from the locale files (meta.*), with og:locale and og:locale:alternate per language. - Each page's canonical is its own language's URL. The landing page's was hard-coded to "/", so /es, /ja and /ar declared themselves duplicates of the English page. - hreflang alternates (and x-default) on the landing page and every docs page; docs list only the languages a page is translated into. - og:url per page: docs pages were inheriting the home page's. - The sitemap lists every page in every language (212 URLs) with alternates. - pathInLocale moves to src/lib/locale-path.ts, shared by the switcher and the metadata.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #96: translated metadata and a locale-aware sitemap.
Fixes an existing SEO bug
The landing page's canonical was hard-coded to `/`, so `/es`, `/ja` and `/ar` all declared themselves duplicates of the English page, and search engines would drop them. Each page now uses its own language's URL as its canonical.
What changed
Verified (`next start`)
Every page has `` for en, es, ja, ar and x-default.
Lint, `format:check`, typecheck, tests, `build`, `build:lib` and `test:pack` all pass.