ci: remove the superseded legacy CodeQL workflow - #2
Conversation
Enabling Advanced Security added .github/workflows/codeql.yml, so the
repository has been running two CodeQL setups in parallel:
codeql-analysis.yml javascript only checkout@v3, codeql-action@v2
codeql.yml javascript-typescript checkout@v7, codeql-action@v4
+ actions
The new one is a strict superset: it covers the same JavaScript/TypeScript
code plus the workflow files themselves, and it is the only one of the two
whose actions are not on the deprecated Node 20 runtime — the legacy file is
the sole remaining source of this warning on every run:
The following actions target Node.js 20 but are being forced to run on
Node.js 24: actions/checkout@v3, github/codeql-action/analyze@v2,
github/codeql-action/autobuild@v2, github/codeql-action/init@v2
bQuery/bQuery already carries codeql.yml alone, so this also brings the two
repositories in line.
Deliberately landed on main by itself rather than inside the DevTools
extension pull request: while the file exists on main but not on a branch,
code scanning reports the missing configuration and fails the aggregate
check. Removing it here first lets that branch pick the deletion up by
merging main, with no window where the two disagree.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request deletes the GitHub Actions workflow that ran CodeQL analysis for JavaScript on pushes, pull requests, and a weekly schedule. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR removes a duplicate legacy CodeQL workflow without reducing the stated scanning coverage or changing product runtime behavior. No actionable merge-blocking risk remains beyond normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deletes
.github/workflows/codeql-analysis.yml. One file, nothing else.Why
Enabling Advanced Security added
codeql.yml, so the repository has been running two CodeQL setups against every commit:codeql-analysis.yml(legacy template)javascriptcheckout@v3,codeql-action@v2codeql.yml(advanced setup)javascript-typescript+actionscheckout@v7,codeql-action@v4The new one is a strict superset — same JS/TS code, plus the workflow files themselves — and it's the only one of the two not on the deprecated Node 20 runtime. The legacy file is the sole remaining source of this warning on every run:
bQuery/bQueryalready carriescodeql.ymlalone, so this also brings the two repositories in line.Why this is a separate pull request
It could have gone into #1, but that would have cost that PR its green status for no good reason. While a configuration exists on
mainand not on a branch, code scanning reports "1 configuration present onrefs/heads/mainwas not found" and fails the aggregate CodeQL check — we hit exactly that failure mode earlier in #1's history.Landing the deletion on
mainfirst means #1 picks it up by mergingmain, with no window where the two sides disagree.Suggested order: merge this first, then #1, then bQuery/bQuery#207.
Risk
Low, and reversible by a revert. Code scanning coverage does not decrease —
codeql.ymlanalyzes a superset of what is removed. The only observable change is one fewer duplicate analysis per commit, and the Node 20 warning disappearing.Validation
Nothing to run: the change is a file deletion, and the remaining workflow is unmodified. CodeQL's own
Analyze (javascript-typescript)andAnalyze (actions)on this PR are the check that coverage still holds.Generated by Claude Code
Summary by CodeRabbit