fix(webkit): give table cells block padding so tall content can breathe - #899
Open
gabriel-lisboa-azion wants to merge 1 commit into
Open
fix(webkit): give table cells block padding so tall content can breathe#899gabriel-lisboa-azion wants to merge 1 commit into
gabriel-lisboa-azion wants to merge 1 commit into
Conversation
gabriel-lisboa-azion
added a commit
that referenced
this pull request
Aug 17, 2026
Brings the three commits demo lacked, so the deployed sample exercises them alongside the four fixes carved out of this branch (#899–#902), whose content was already here: - feat(webkit): chip's three kinds (#883) - feat(theme): the semantic/layouts container system (#884) - feat(theme): lightened heading and body type (#876) Conflict resolutions worth knowing: `build-tokens.mjs` — main has no illustration tokens, so main's side of all six hunks was empty. Taking it would have silently deleted this branch's illustration wiring; ours was kept. The merge then produced a DUPLICATE `emitUtilities` and `emitLayoutUtilities` with no conflict at all (both sides had added an identical helper in different places), which is a syntax error the merge itself reported as clean — the second copy is removed and `emitIllustrationUtilities` reuses the first. `texts.data.js` — the five conflicts were all `text-body-*` weight, resolved to main's `light` since that is the change being previewed. Resolved in place rather than with `--theirs`, which would have discarded the file's auto-merged hunks. Entry count held at 144. `.size-limit.json` — union, not a side: main's `chip` plus this branch's `footer-root` and `resizable-panel-root`. `dist/v4/globals.*` are generated, so they were rebuilt from the merged sources rather than hand-merged. The 466 conflicting visual baselines took main's copies; neither side is valid for a merged tree, and this branch opens no PR the visual gate guards. Verified after: no `undefined` in the built CSS, illustration tokens still emitted, main's layout utilities present, body weights now 300, no token data file lost entries, and 154 tests pass across toast, table, sidebar, resizable-panel and chip.
A cell was `min-h-12` with horizontal padding only. For a single-line cell that is invisible — the 48px minimum decides the height on its own against ~20px of text — so every existing row renders exactly as before. It only shows on a cell whose content is TALLER than the minimum: a wrapped list of tags, a two-line summary. There the height came from the content alone, which put the first and last lines flush against the row's borders with no breathing room at all.
gabriel-lisboa-azion
force-pushed
the
fix/table-cell-block-padding
branch
from
August 17, 2026 12:37
b79d48b to
ab606ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TableCellhad horizontal padding only, so its height came frommin-h-12alone. Addspy-(--spacing-xs).How to test
cd packages/webkit && npx vitest run src/components/data/table→ passes.pnpm storybook:dev→ Components/Data/Table. Existing stories are pixel-identical (row height still 48px). In a cell with wrapped content (multiple tags), the content no longer touches the row border above and below.Notes