fix(webkit): draw the progress bar's track on --bg-placeholder - #893
Open
gabriel-lisboa-azion wants to merge 2 commits into
Open
fix(webkit): draw the progress bar's track on --bg-placeholder#893gabriel-lisboa-azion wants to merge 2 commits into
gabriel-lisboa-azion wants to merge 2 commits into
Conversation
The track was an opaque raised surface, so it only held its 3:1 contrast against the fill on the one background that surface was picked for. --bg-placeholder is an alpha overlay, so the track keeps that contrast on any background the bar is placed over — canvas, surface, raised or overlay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--bg-surface-raised, an opaque surface, so its 3:1 contrast against the fill only held on the background that token was chosen for. On a raised or overlay background the track disappeared into it.--bg-placeholderis an alpha overlay, so the track keeps its contrast on any background the bar sits over. Spec's Theme gaps + a11y notes updated to match (checksum +last_updatedrefreshed).How to test
cd packages/webkit && npx vitest run src/components/feedback/progress-bar→ 18 passed.pnpm storybook:dev→ Components/Feedback/ProgressBar. The track reads as a recessed groove in both themes; place a bar inside aCardBox(raised) and inside a Dialog (overlay) and the track is still visible against both.Notes
catalog.jsonneeds no rebuild (--bg-placeholderis already in its token set).