Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions sagemaker-train/src/sagemaker/train/rlvr_trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ def _process_hyperparameters(self):
if hasattr(self.hyperparameters, 'reward_lambda_arn'):
delattr(self.hyperparameters, 'reward_lambda_arn')
self.hyperparameters._specs.pop('reward_lambda_arn', None)
if hasattr(self.hyperparameters, 'preset_reward_function'):
delattr(self.hyperparameters, 'preset_reward_function')
self.hyperparameters._specs.pop('preset_reward_function', None)
if hasattr(self.hyperparameters, 'data_path'):
delattr(self.hyperparameters, 'data_path')
self.hyperparameters._specs.pop('data_path', None)
Expand Down Expand Up @@ -410,7 +407,22 @@ def train(self, training_dataset: Optional[Union[str, DataSet]] = None,

Returns:
TrainingJob: The SageMaker training job object, or None if dry_run=True.

Raises:
ValueError: If neither a custom reward function nor a preset reward
function hyperparameter is configured.
"""
# A reward signal is required: either a custom reward function (Lambda ARN,
# evaluator ARN, or Evaluator object) or the preset_reward_function hyperparameter.
preset_reward_function = getattr(self.hyperparameters, "preset_reward_function", None)
if not self.custom_reward_function and not preset_reward_function:
raise ValueError(
"RLVR training requires a reward signal. Provide either "
"'custom_reward_function' (a Lambda ARN, evaluator ARN, or Evaluator object) "
"when initializing RLVRTrainer, or set the 'preset_reward_function' "
"hyperparameter (e.g. trainer.hyperparameters.preset_reward_function = 'prime_code')."
)

# Dispatch based on compute type
if isinstance(self.compute, HyperPodCompute):
return self._train_hyperpod(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ def test_rlvr_trainer_lora_complete_workflow(sagemaker_session):
accept_eula=True,
base_job_name=f"rlvr-lora-integ-{unique_id}",
)

rlvr_trainer.hyperparameters.preset_reward_function = "prime_code"

# Create training job
training_job = rlvr_trainer.train(wait=False)
Expand Down
Loading