[DO NOT MERGE] Add hyp create ray-dashboard-connection command - #446
[DO NOT MERGE] Add hyp create ray-dashboard-connection command#446jchatter321 wants to merge 1 commit into
Conversation
| if connection_url: | ||
| click.echo(connection_url) | ||
| else: | ||
| click.echo(f"RayDashboardConnection created in namespace '{namespace}' for cluster '{cluster_name}'") |
There was a problem hiding this comment.
This can never happen because agg APIs are sychronous. Lets fail with an error message 'contact your administrator' or something when URL is null / empty.
There was a problem hiding this comment.
Added exception.
| """Create a RayDashboardConnection to get a dashboard URL for a RayCluster.""" | ||
| api_client = _get_eks_api_client() | ||
|
|
||
| body = { |
There was a problem hiding this comment.
Can we handle the case where the ray endpoint operator is not installed gracefully? If kind RayDashboardConnection is not recognized by the API server, lets instruct customers to install ray-endpoint-operator (we'll come back and link the docs when it's ready)
There was a problem hiding this comment.
Added exception below.
b4aeb21 to
4281c4a
Compare
|
Did we update the help message or add documentation for this new command: |
We plan to release public documentation containing this information. |
4281c4a to
98d3755
Compare
98d3755 to
0a8d259
Compare
Adds a CLI command to create a RayDashboardConnection CR and return the dashboard URL.
Usage:
Returns the connection URL from the operator's extension API. Flag
--namespacedefaults todefaultnamespace if not provided.Testing
Installed CLI with
pip install -e .and successfully generated a RayDashboardConnection usinghyp create ray-dashboard-connection --cluster-name my-raycluster.Unit tests -