Scope react-compiler refs suppression to react-table options - #2200
Open
danielvanza wants to merge 1 commit into
Open
danielvanza wants to merge 1 commit into
danielvanza wants to merge 1 commit into
Conversation
Contributor
Author
|
Checks haven't started yet, I think they need a maintainer to approve the workflow run for first-time contributors. Whenever someone gets a chance, kicking off CI and reviewing would be great. The change is only the one re-enable directive in useTabular.ts. |
danielvanza
marked this pull request as ready for review
September 19, 2026 14:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useTabular.ts:435fromreact-hooks/refstoreact-compiler/refsso it pairs with the disable at:427.Validation
pnpm check:lint— passed with no new violations.useTable(...)result to a local and addedskipPageResetRef.current = true;after it (the plan's append point before the closing};is after the hook'sreturn, so it is unreachable).pnpm check:lint packages/graph-explorer/src/components/Tabular/useTabular.tsreportedreact-compiler(refs): Cannot update ref during render, confirming the rule is active after the re-enable. With the oldeslint-enable react-hooks/refsdirective the same code produced no diagnostic, confirming the prior leak. The temporary edit was reverted.pnpm checks— passed.pnpm test— passed (222 files, 2705 tests).Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.