Skip to content

Scope react-compiler refs suppression to react-table options - #2200

Open
danielvanza wants to merge 1 commit into
aws:mainfrom
danielvanza:fix-refs-suppression-scope
Open

danielvanza wants to merge 1 commit into
aws:mainfrom
danielvanza:fix-refs-suppression-scope

Conversation

@danielvanza

Copy link
Copy Markdown
Contributor

Description

  • Change the re-enable directive at useTabular.ts:435 from react-hooks/refs to react-compiler/refs so it pairs with the disable at :427.
  • The suppression now applies only to the react-table options object instead of leaking to the end of the file.

Validation

  • pnpm check:lint — passed with no new violations.
  • Deliberate violation: temporarily bound the useTable(...) result to a local and added skipPageResetRef.current = true; after it (the plan's append point before the closing }; is after the hook's return, so it is unreachable). pnpm check:lint packages/graph-explorer/src/components/Tabular/useTabular.ts reported react-compiler(refs): Cannot update ref during render, confirming the rule is active after the re-enable. With the old eslint-enable react-hooks/refs directive the same code produced no diagnostic, confirming the prior leak. The temporary edit was reverted.
  • pnpm checks — passed.
  • pnpm test — passed (222 files, 2705 tests).

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I have verified pnpm checks passes with no errors.
  • I have verified pnpm test passes with no failures.
  • I have covered new added functionality with unit tests if necessary.
  • I have updated documentation if necessary.

@danielvanza

Copy link
Copy Markdown
Contributor Author

Checks haven't started yet, I think they need a maintainer to approve the workflow run for first-time contributors. Whenever someone gets a chance, kicking off CI and reviewing would be great. The change is only the one re-enable directive in useTabular.ts.

@danielvanza
danielvanza marked this pull request as ready for review September 19, 2026 14:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mismatched refs lint suppression scope in useTabular

1 participant