Remove unused https dependency from the proxy server - #2197
Open
danielvanza wants to merge 1 commit into
Open
danielvanza wants to merge 1 commit into
danielvanza wants to merge 1 commit into
Conversation
Author
|
Looks like the CI runs are stuck on "awaiting approval" since this is my first PR here. If a maintainer could approve them and take a look when there's time, that would be much appreciated. It's just the unused |
danielvanza
marked this pull request as ready for review
September 19, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
httpsnpm dependency fromgraph-explorer-proxy-server; the imports resolve to Node's built-inhttpscore module, which shadows any same-named package.pnpm-lock.yaml, dropping the dead importer, package, and snapshot entries.Validation
pnpm install --frozen-lockfile— lockfile consistent.rg -n "https@" pnpm-lock.yaml— nohttps@1.0.0entries remain.pnpm checks— passed.pnpm test— passed (222 files, 2705 tests).PROXY_SERVER_HTTPS_CONNECTION=false PROXY_SERVER_HTTP_PORT=9250 pnpm build && pnpm start, thencurl -sS http://localhost:9250/status— returnedOK(HTTP 200); log lineProxy server located at http://localhost:9250.Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.