Skip to content

fix: clarify empty neighbor expansion with filters - #2170

Open
Ani2828 wants to merge 1 commit into
aws:mainfrom
Ani2828:fix/filter-neighbor-toast
Open

Ani2828 wants to merge 1 commit into
aws:mainfrom
Ani2828:fix/filter-neighbor-toast

Conversation

@Ani2828

@Ani2828 Ani2828 commented Sep 14, 2026

Copy link
Copy Markdown

Description

Fixes #2060.

When expanding neighbors with attribute filters, an empty result previously
displayed "No more neighbors to expand", which incorrectly implied that the
node had no remaining neighbors.

This change distinguishes between:

  • No filters + empty result → "No more neighbors to expand"
  • Attribute filters + empty result → "No neighbors matched your filters"

The logic is applied to both single-node and multi-node expansion paths.

Validation

  • pnpm lint — passed with 0 warnings and 0 errors
  • pnpm check:types — passed
  • git diff --check — passed

The full test suite currently reports 57 failed tests and 2611 passed tests.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading "No more neighbors to expand" message when filters exclude all neighbors

1 participant