Repository navigation
chore(deps): bump vite to 8.3.4 to clear GHSA-698v-4r3x-3vcv - #2634
Conversation
`bun audit` fails the verify workflow on a moderate advisory in vite 8.3.0: launch-editor's escapeCmdArgs() omits % escaping on Windows, affecting >=8.3.0 <=8.3.2. vite is a transitive dev-only dependency (vitest > @vitest/mocker > vite) and vitest already declares `vite: ^6.0.0 || ^7.0.0 || ^8.0.0`, so 8.3.4 resolves within the existing range. Lockfile only; package.json is unchanged.
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
This PR is a lockfile-only update (bun.lock) bumping patch versions of transitive dev dependencies pulled in via vitest:
vite8.3.0 → 8.3.4rolldown1.2.9 → 1.2.14 (and all its platform bindings)postcss8.5.28 → 8.5.31nanoid3.3.19 → 3.3.20@oxc-project/types0.150.0 → 0.154.0
No package.json changes, no source changes, and no changes to runtime dependencies — these only affect the test toolchain. Nothing to flag re: mocking or telemetry since no behavior changed. Assuming CI (tests + bundle build) is green, this is safe to merge.
|
Claude Security Review: no high-confidence findings. (run) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2634 +/- ##
============================================
- Coverage 96.62% 96.61% -0.01%
============================================
Files 706 706
Lines 58502 58460 -42
============================================
- Hits 56527 56484 -43
- Misses 1975 1976 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
bun run auditexits 1 onrefactor, failing thebun auditgate in.github/workflows/verify.yml:bun update vitetakes it 8.3.0 -> 8.3.4. The advisory caps at 8.3.2, andvitest@4.1.11already declaresvite: ^6.0.0 || ^7.0.0 || ^8.0.0, so 8.3.4 resolves inside the existing range.Lockfile only —
bun.lock, +20/-20.package.jsonis unchanged. No new--ignoreentry, because the advisory is actually resolved rather than suppressed.Impact of the advisory itself
Low.
viteis a transitive dev-only dependency that backs the e2e runner invitest.e2e.config.ts. It is not in the published npm bundle. The practical cost was a red required check on every PR.Related Issue
Documentation PR
Not applicable — no user-facing behavior or documented surface changes.
Type of Change
Testing
bun test— 4705 pass, 0 fail, 311 filesbun run test:e2e, or explained why they are not applicable — did not run against live AWS, but since this bumps the e2e runner's ownvite, I verified collection still works:AGENTCORE_CLI_PATH=... bunx vitest list --config vitest.e2e.config.tsenumerates all 24 e2e tests under 8.3.4bun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots —src/assets/not touchedAnd the point of the change:
bun run audit—No vulnerabilities found (checked 798 packages, 1 ignored)Checklist
bun auditinverify.ymlis the regression check