Repository navigation
fix(tui): support branch selection in config bundle flow - #2627
Merged
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice refactor — inserting a branch picker between the bundle list and the detail view, with the new latestPerBranch filter driving it, hangs together cleanly.
A few things I checked that are fine as-is:
- Route specificity in
Root.tsx: the static-segment routeget/:bundleId/branch/:branchNameis declared beforeget/:bundleId/:versionId, and React Router v6 scores the static segment higher regardless of declaration order, so aversionIdcolliding with the literal"branch"would still route correctly. getConfigurationBundlewith aversionId:branchNameis ignored by the client in that branch, so defaulting to"mainline"inscreen.tsxwhenversionIdis present is harmless.- Query key disambiguation: adding the
"branch"/"version"discriminator to theuseQuerykey avoids cross-contamination between the two modes. Good. - Testing style: tests use the real
TestCoreClientand only stub at the SDK boundary — consistent with the project's "no excessive mocking" guidance. - Telemetry: none added, but no sibling eval screens instrument telemetry today, so this isn't a regression.
No blocking issues from me.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2627 +/- ##
=========================================
Coverage 96.61% 96.62%
=========================================
Files 704 706 +2
Lines 58404 58494 +90
=========================================
+ Hits 56429 56519 +90
Misses 1975 1975 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
jariy17
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The config bundle TUI currently is unable to render a bundle which was not created with the default 'mainline' branch. The TUI always expects mainline, thus a bundle with a custom branch would fail to render, and show the user an error.
This PR adds a branch selection screen to the config bundle selection flow. After selecting a bundle, the user is prompted to select the branch they intend to view. This follows the pattern established for runtime-endpoint qualifier, and config-bundle version.
The follow video shows:
agentcore ...command, fails to load bundleac-dev ...user is prompted to select branch, and bundle is renderedScreen.Recording.2026-10-20.at.3.17.04.PM.mov
Type of Change
Testing
How have you tested the change?
bun run test(4698 pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.